Merge lp:~dandrader/unity8/fixBuild_lp1328850 into lp:unity8

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 964
Merged at revision: 965
Proposed branch: lp:~dandrader/unity8/fixBuild_lp1328850
Merge into: lp:unity8
Diff against target: 24 lines (+3/-0)
2 files modified
tests/mocks/libusermetrics/UserMetrics.cpp (+1/-0)
tests/plugins/Unity/Indicators/unitymenumodelstacktest.cpp (+2/-0)
To merge this branch: bzr merge lp:~dandrader/unity8/fixBuild_lp1328850
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+222845@code.launchpad.net

Commit message

Fix build problems. Reviewed by: Michael Terry

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Worked for me.

review: Approve
964. By Daniel d'Andrada

Fix build

"""
tests/plugins/Unity/Indicators/unitymenumodelstacktest.cpp:151:23: error: ‘std::function’ has not been declared
     bool waitFor(std::function<bool()> functor, int ms) {
"""

Revision history for this message
Michael Terry (mterry) wrote :

OK, actually went all the way through a build this time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/mocks/libusermetrics/UserMetrics.cpp'
--- tests/mocks/libusermetrics/UserMetrics.cpp 2013-12-17 14:56:25 +0000
+++ tests/mocks/libusermetrics/UserMetrics.cpp 2014-06-11 17:28:04 +0000
@@ -18,6 +18,7 @@
1818
19#include "UserMetrics.h"19#include "UserMetrics.h"
20#include <qvariantlistmodel.h>20#include <qvariantlistmodel.h>
21#include <functional>
2122
22#include <QtCore/QDir>23#include <QtCore/QDir>
23#include <QtCore/QString>24#include <QtCore/QString>
2425
=== modified file 'tests/plugins/Unity/Indicators/unitymenumodelstacktest.cpp'
--- tests/plugins/Unity/Indicators/unitymenumodelstacktest.cpp 2013-12-12 12:25:20 +0000
+++ tests/plugins/Unity/Indicators/unitymenumodelstacktest.cpp 2014-06-11 17:28:04 +0000
@@ -24,6 +24,8 @@
24#include <QDebug>24#include <QDebug>
25#include <unitymenumodel.h>25#include <unitymenumodel.h>
2626
27#include <functional>
28
27class UnityMenuModelStackTest : public QObject29class UnityMenuModelStackTest : public QObject
28{30{
29 Q_OBJECT31 Q_OBJECT

Subscribers

People subscribed via source and target branches