Code review comment for lp:~dandrader/unity8/dragHandleStretchAndHint

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> 70 + property var __previousStatus: undefined
> 71 + property real __startValue
> 72 + property real __minValue:
> 74 + property real __maxValue:
> 78 + property string __targetProp: {
>
> Can you create a private QtObject to encapsulate these as per guidelines
> https://docs.google.com/a/canonical.com/document/d/1gd87Wo_CSB0DpFWLpTKIIXQfdm
> Fncrq0PHSr9H2PTnk/edit

Done.

>
> 72 + property real __minValue:
> 73 + Direction.isPositive(direction) ? __startValue : __startValue
> - maxTotalDragDistance
> 74 + property real __maxValue:
> 75 + Direction.isPositive(direction) ? __startValue +
> maxTotalDragDistance : __startValue
>
> Expression on a new line?

Otherwise the line would be quite long. Done it differently now.

>
> 368 + x = 0
> 369 + width = 0
> 370 + } else {
> 371 + x = -parent.width
> 372 + width = parent.width
>
> 456 + rect.clicked()
>
> 482 + y = 0
> 483 + height = 0
> 484 + } else {
> 485 + y = -parent.height
> 486 + height = parent.height
>
> Semi-colons.

Done.

« Back to merge proposal