Code review comment for lp:~dandrader/unity8/drag-crash-1228336

Revision history for this message
Michael Zanetti (mzanetti) wrote :

This looks really good. The crashes are definitely gone.

=======
can we const & all occurances of "SharedTimeSource timeSource" in method arguments?

=======
715 + // Estimate of the maximum number of active touches we might reach.
716 + // Not a problem if it ends up being an underestimate as this is just
717 + // an optimization.
718 + reserve(10);

If it's just an optimization, shouldn't we rather go for 3 or something that is more realistic? I think it happens max once a year that I touch the screen with all 10 fingers.

review: Needs Information

« Back to merge proposal