Code review comment for lp:~dandrader/unity8/ddaImprovements

Revision history for this message
Albert Astals Cid (aacid) wrote :

Had another look at this and for what my manual testing and looking and the code says it's fine, next time i would really appreciate if you do not rebase everything into a single commit since it makes reviewing the changes from the last time i did a review much harder since basically i have to look at it all.

Leaving top un-approved to let others have a look.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
Yes, to the extend it passes everywhere else

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

« Back to merge proposal