Code review comment for lp:~dandrader/unity8/ddaImprovements
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> 2838- if (status !== DirectionalDrag
> launcher.state == "visible")
> 2839+ if (!dragging || launcher.state == "visible")
>
> This seems to make the launcher jump a little... also design wants to see the
> launcher's shadow immediately when you touch the edge.
>
> My suggestion would be a "pressed" property in the DirectionalDragArea that
> could be used for that.
Added the pressed property. It's needed in the Greeter.
Made Launcher use it although I don't think it makes a difference. What did solve Launcher's jumpiness was making it use DDA.distance instead of DDA.touchX, since the former starts from 0 whereas the latter starts from the X position from the the drag started (eg: touchStartPos.x())