Code review comment for lp:~dandrader/unity8/autoInstallTouchRegistry

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> tst_TouchRegistry fails with an assertion...
>
> QFATAL : tst_TouchRegistry::requestWithNoCandidates() ASSERT: "m_instance !=
> nullptr" in file
> /tmp/unity8-autoInstallTouchRegistry/libs/UbuntuGestures/TouchRegistry.cpp,
> line 52
> FAIL! : tst_TouchRegistry::requestWithNoCandidates() Received a fatal error.
>
> ... in ./libs/UbuntuGestures/TouchRegistry.cpp there's...
>
> TouchRegistry::~TouchRegistry()
> {
> Q_ASSERT(m_instance != nullptr); // Kaboom!
> m_instance = nullptr;
> delete m_timerFactory;
> }

Fixed. Should have spotted this before, sorry.

review: Needs Resubmitting

« Back to merge proposal