Code review comment for lp:~dandrader/unity/phablet_improve_cmake_add_qml_test

> 16 +# IMPORT_PATHS will pass that path to qmltestrunner as "-import"
> arguments
> "those paths"

will fix

>
> 25 + set(multi_value_keywords "IMPORT_PATHS" "TARGETS" "PROPERTIES")
> no need for the quotes

will change

>
> 28 + cmake_parse_arguments(qmltest "${options}" ""
> "${multi_value_keywords}" ${ARGN})
> rogue space

This is not a rogue space. This is the argument for single-valued keywords, which we have none now.

>
> 47 + list(APPEND qmltestrunner_imports "-import")
> 48 + list(APPEND qmltestrunner_imports ${IMPORT_PATH})
> I would probably just go and set(var "${var} -import ${IMPORT_PATH}") here,
> but that's good, too

Appending has better performance. But I could probably merge the two in a single append command.