Code review comment for lp:~dandrader/unity/phablet_improve_cmake_add_qml_test

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

16 +# IMPORT_PATHS will pass that path to qmltestrunner as "-import" arguments
"those paths"

25 + set(multi_value_keywords "IMPORT_PATHS" "TARGETS" "PROPERTIES")
no need for the quotes

28 + cmake_parse_arguments(qmltest "${options}" "" "${multi_value_keywords}" ${ARGN})
rogue space

47 + list(APPEND qmltestrunner_imports "-import")
48 + list(APPEND qmltestrunner_imports ${IMPORT_PATH})
I would probably just go and set(var "${var} -import ${IMPORT_PATH}") here, but that's good, too

Just some nitpicks, otherwise good!

review: Needs Fixing

« Back to merge proposal