Code review comment for lp:~dandrader/unity/phablet_edgeDragGesture

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> 889 + bool dragging() const { return m_status && (Undecided ||
> Recognized); }
>
> This looks incorrect. Undecided || Recognized is always true (assuming their
> values are 1 and 2, respectively) so dragging becomes (bool)m_status, which
> will, only be false in WaitingForTouch status.

Right, they're not flags. Silly mistake. Fixed.

« Back to merge proposal