Merge lp:~dandrader/unity-api/surfaceItemSizeHints into lp:unity-api

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp:~dandrader/unity-api/surfaceItemSizeHints
Merge into: lp:unity-api
Diff against target: 99 lines (+56/-1)
3 files modified
debian/changelog (+6/-0)
include/unity/shell/application/CMakeLists.txt (+1/-1)
include/unity/shell/application/MirSurfaceInterface.h (+49/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/surfaceItemSizeHints
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+278740@code.launchpad.net

This proposal has been superseded by a proposal from 2016-02-03.

Commit message

MirSurfaceInterface: added size hints

Description of the change

MirSurfaceInterface: added size hints

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM, approving

review: Approve
202. By Daniel d'Andrada

Add MirSurfaceItem.fillMode
Approved by: Michael Zanetti

203. By Michael Terry

Added ApplicationInfoInterface::exemptFromLifecycle Fixes: #1518764
Approved by: PS Jenkins bot, Daniel d'Andrada

204. By CI Train Bot Account

Releasing 7.104+16.04.20151207-0ubuntu1

205. By Daniel d'Andrada

MirSurfaceInterface: added size hints

Unmerged revisions

205. By Daniel d'Andrada

MirSurfaceInterface: added size hints

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-12-07 16:21:29 +0000
+++ debian/changelog 2015-12-14 10:04:26 +0000
@@ -1,3 +1,9 @@
1unity-api (7.105) UNRELEASED; urgency=medium
2
3 * MirSurfaceInterface: added size hints
4
5 -- Daniel d'Andrada <daniel.dandrada@canonical.com> Mon, 14 Dec 2015 07:53:47 -0200
6
1unity-api (7.104+16.04.20151207-0ubuntu1) xenial; urgency=medium7unity-api (7.104+16.04.20151207-0ubuntu1) xenial; urgency=medium
28
3 [ Daniel d'Andrada ]9 [ Daniel d'Andrada ]
410
=== modified file 'include/unity/shell/application/CMakeLists.txt'
--- include/unity/shell/application/CMakeLists.txt 2015-12-03 19:32:37 +0000
+++ include/unity/shell/application/CMakeLists.txt 2015-12-14 10:04:26 +0000
@@ -7,7 +7,7 @@
77
8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
99
10set(VERSION 12)10set(VERSION 13)
11set(PKGCONFIG_NAME "unity-shell-application")11set(PKGCONFIG_NAME "unity-shell-application")
12set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")12set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
13set(PKGCONFIG_REQUIRES "Qt5Core")13set(PKGCONFIG_REQUIRES "Qt5Core")
1414
=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
--- include/unity/shell/application/MirSurfaceInterface.h 2015-10-26 18:26:01 +0000
+++ include/unity/shell/application/MirSurfaceInterface.h 2015-12-14 10:04:26 +0000
@@ -78,6 +78,42 @@
78 Q_PROPERTY(Mir::OrientationAngle orientationAngle READ orientationAngle WRITE setOrientationAngle78 Q_PROPERTY(Mir::OrientationAngle orientationAngle READ orientationAngle WRITE setOrientationAngle
79 NOTIFY orientationAngleChanged DESIGNABLE false)79 NOTIFY orientationAngleChanged DESIGNABLE false)
8080
81 /**
82 * @brief The requested minimum width for the surface
83 * Zero if not set
84 */
85 Q_PROPERTY(int minimumWidth READ minimumWidth NOTIFY minimumWidthChanged)
86
87 /**
88 * @brief The requested minimum height for the surface
89 * Zero if not set
90 */
91 Q_PROPERTY(int minimumHeight READ minimumHeight NOTIFY minimumHeightChanged)
92
93 /**
94 * @brief The requested maximum width for the surface
95 * Zero if not set
96 */
97 Q_PROPERTY(int maximumWidth READ maximumWidth NOTIFY maximumWidthChanged)
98
99 /**
100 * @brief The requested maximum height for the surface
101 * Zero if not set
102 */
103 Q_PROPERTY(int maximumHeight READ maximumHeight NOTIFY maximumHeightChanged)
104
105 /**
106 * @brief The requested width increment for the surface
107 * Zero if not set
108 */
109 Q_PROPERTY(int widthIncrement READ widthIncrement NOTIFY widthIncrementChanged)
110
111 /**
112 * @brief The requested height increment for the surface
113 * Zero if not set
114 */
115 Q_PROPERTY(int heightIncrement READ heightIncrement NOTIFY heightIncrementChanged)
116
81public:117public:
82 /// @cond118 /// @cond
83 MirSurfaceInterface(QObject *parent = nullptr) : QObject(parent) {}119 MirSurfaceInterface(QObject *parent = nullptr) : QObject(parent) {}
@@ -100,6 +136,13 @@
100136
101 virtual Mir::OrientationAngle orientationAngle() const = 0;137 virtual Mir::OrientationAngle orientationAngle() const = 0;
102 virtual void setOrientationAngle(Mir::OrientationAngle angle) = 0;138 virtual void setOrientationAngle(Mir::OrientationAngle angle) = 0;
139
140 virtual int minimumWidth() const = 0;
141 virtual int minimumHeight() const = 0;
142 virtual int maximumWidth() const = 0;
143 virtual int maximumHeight() const = 0;
144 virtual int widthIncrement() const = 0;
145 virtual int heightIncrement() const = 0;
103 /// @endcond146 /// @endcond
104147
105Q_SIGNALS:148Q_SIGNALS:
@@ -111,6 +154,12 @@
111 void orientationAngleChanged(Mir::OrientationAngle value);154 void orientationAngleChanged(Mir::OrientationAngle value);
112 void sizeChanged(const QSize &value);155 void sizeChanged(const QSize &value);
113 void nameChanged(const QString &name);156 void nameChanged(const QString &name);
157 void minimumWidthChanged(int value);
158 void minimumHeightChanged(int value);
159 void maximumWidthChanged(int value);
160 void maximumHeightChanged(int value);
161 void widthIncrementChanged(int value);
162 void heightIncrementChanged(int value);
114 /// @endcond163 /// @endcond
115};164};
116165

Subscribers

People subscribed via source and target branches

to all changes: