Code review comment for lp:~dandrader/unity-api/mirSurface

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 22/07/15 08:08, Gerry Boland wrote:
> Review: Needs Information
>
> + * @brief Width of the contained MirSurface, if any
> + * If set, it means the desired width for the contained MirSurface. Otherwise it has
> + * the current width of the contained MirSurface.
> + Q_PROPERTY(int surfaceWidth READ surfaceWidth
>
> Kind confusing. What if I set a new width, but then want to read the current width?
>
> Did you get anywhere looking into implicitHeight/Width to be readonly values which always reflect the current actual size of the surface?
>
> If so, then the purpose of surfaceWidth/Height can be made more clear: it sets the surfaceWidth/Height we desire. A rename might be needed, e.g. requestedSurfaceWidth/Height

Fixed.

« Back to merge proposal