Code review comment for lp:~dandrader/unity-api/lifecycle

Revision history for this message
Gerry Boland (gerboland) wrote :

I dislike this API as it only makes sense when an Application having 1 surface, which is not going to be true in future.

Why can't we just have the screenshot being obtained by an image provider? Why would Application save its screenshot internally at all? It was useful before QtComp, as it was a cacheing system that made sense at the time, but now I don't see the benefit at all.

Aside: in adding new methods, you need to add them to this QML test: test/qmltest/unity/shell/application/tst_Application.qml

review: Needs Fixing

« Back to merge proposal