Code review comment for lp:~dandrader/qtubuntu/betterSessionName

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 01/06/2016 12:58, Gerry Boland wrote:
> Yeah, that's ok. I just want to keep app startup light, using QFileInfo to parse a file name just strikes me as heavy for something that only those reading file logs will appreciate. But I won't block on that.

QFileInfo creation looks pretty tame and lightweight. It pretty much
just stores the given filepath in a internal string.

The only real code we execute happens when we call QFileInfo::fileName,
where it essentially finds the last separator char in the string and
then "return m_filePath.mid(m_lastSeparator + 1);".

« Back to merge proposal