Code review comment for lp:~dandrader/qtubuntu/betterSessionName

Revision history for this message
Gerry Boland (gerboland) wrote :

+for (int i = 0; i < args.count(); ++i) {
+ QString arg = args[i];
We have Q_FOREACH

Do you really need to read the FileInfo object? Why not just drop the ".qml" from the file name?

+ u_application_id_new_from_stringn(sessionName.data(), sessionName.count());
Does the api expect sessionName to always exist, or will it make a copy itself?

review: Needs Fixing

« Back to merge proposal