Code review comment for lp:~dandrader/qtubuntu/betterSessionName

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 01/06/2016 09:48, Nick Dedekind wrote:
>> +QByteArray UbuntuClientIntegration::generateSessionName(QStringList &args)
>> >+{
> Perhaps use QApplication::applicationName first? I actually had a branch for this about a thousand years ago, but it never went anywhere.
>

QApplication::applicationName might not be set yet when
QPlatformIntegration is created (which is really early). It can be set
or even changed at any time by calling
QCoreApplicaiton::setApplicationName, and we would have not way of
updating your session id to follow those changes. So the only thing sure
to exist at QPlatformIntegration creation is the application arguments.

« Back to merge proposal