Code review comment for lp:~dandrader/qtmir/promptBeforeSurfaceDraws

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 11/05/2016 09:54, Nick Dedekind wrote:
> Sorry, I misunderstood the code, but it seems that you might be prepending the surface twice. Once if you add a prompt when it's blank, and again when it's drawn it's first frame.
prompt session surfaces are added to its parent session's
promptSurfaceList only in Session::addChildSession. And that's called
only once per prompt session.

Once the once-blank has drawn its first frame it's moved to the
Session's surface list. But that move doesn't affect the surfaces own
promptSurfaceList.

« Back to merge proposal