> On 11/05/2016 06:17, Nick Dedekind wrote:
> > The prompt will still be childed to the blank surface which I think is
> wrong.
>
> So you think a prompt surface should be treated as a top-level
> application surface? Or is it the problem just that the parent surface
> is still blank?
The Mir implementation of prompts has not got surfaces in mind, they're properties of a session. We've just forced it to be a child the first surface.
I'm not saying the current mir impl is correct; and we'll have trouble as soon as 2 top level surfaces require prompts at the same time...
Sorry, I misunderstood the code, but it seems that you might be prepending the surface twice. Once if you add a prompt when it's blank, and again when it's drawn it's first frame.
> On 11/05/2016 06:17, Nick Dedekind wrote:
> > The prompt will still be childed to the blank surface which I think is
> wrong.
>
> So you think a prompt surface should be treated as a top-level
> application surface? Or is it the problem just that the parent surface
> is still blank?
The Mir implementation of prompts has not got surfaces in mind, they're properties of a session. We've just forced it to be a child the first surface.
I'm not saying the current mir impl is correct; and we'll have trouble as soon as 2 top level surfaces require prompts at the same time...
Sorry, I misunderstood the code, but it seems that you might be prepending the surface twice. Once if you add a prompt when it's blank, and again when it's drawn it's first frame.