Code review comment for lp:~dandrader/qtmir/promptBeforeSurfaceDraws
Revision history for this message
| Gerry Boland (gerboland) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I suspect we should abandon the "only notify qml of new surface after its first frame" thing - and instead have a flag on the MirSurface{,Item} saying "notDrawnToYet" - instead of this blank surface idea.
Like Nick, I'm not a big fan of the blank surface idea either, but I see why you did it. It is the least complex change to fix the issue.
But the "only notify qml of new surface after its first frame" policy is not a Mir policy, just a QtMir policy, and it seems to hurt us here.
Dropping that policy causes us new problems: how does QML draw a MirSurfaceItem which is backed by a mirSurface which was never drawn to. I suppose we do as you do here: make it blank. unity8 will need work to reflect QtMir's behaviour change too.
This what I envision as the proper fix is a much more involved change, not so easily done if it needs to land quickly. We might need to land this (with a FIXME), but we should investigate a proper fix afterwards.