Merge lp:~dandrader/qtmir/multiSurfaceApp into lp:qtmir

[Daniel d'Andrada]

Make Session hold multiple surfaces

* Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~dandrader/unity8/multiSurfaceApp/+merge/271613

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:353
http://jenkins.qa.ubuntu.com/job/qtmir-ci/353/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/86/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/86/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/353/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:354
http://jenkins.qa.ubuntu.com/job/qtmir-ci/356/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/89/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/89/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/356/rebuild

review: Needs Fixing (continuous-integration)

[lp:~dandrader/qtmir/multiSurfaceApp]

359. By Daniel van Vugt on 2015-08-12

MirSurfaceItem: Remove an unnecessary and potentially infinite loop
(LP: #1477430)

We only need to "drop" or consume one frame to do the job of waking
the client up.
 Fixes: #1477430
Approved by: Gerry Boland, PS Jenkins bot

360. By Gerry Boland on 2015-08-12

authorizeSession incorrectly edits desktopFilePath supplied by desktop_file_hint Fixes: #1483225
Approved by: Daniel d'Andrada, PS Jenkins bot

361. By Gerry Boland on 2015-08-12

Standardize licences to LGPLv3, update years, remove authors Fixes: #1483664
Approved by: Daniel d'Andrada

362. By Gerry Boland on 2015-08-12

Add vivid changelog entry as it was released

363. By CI Train Bot Account on 2015-08-12

Releasing 0.4.5+15.04.20150812.1-0ubuntu1

[Gerry Boland (gerboland)]

Please merge trunk, many conflicts have appeared.

+void Session::appendSurface
+void Session::reallyAppendSurface
these names confuse me. Perhaps rename to something like:
appendSurface -> registerSurface
reallyAppendSurface -> appendSurface

 qDebug() << "Application::suspend - no surface to call stopFrameDropper() on!";
I think we can move this to category logging

+ return const_cast<ObjectListModel<MirSurfaceInterface>*>(&m_surfaces);
const_cast needed here? Can't the pointer be a pointer to a const object?

=== modified file 'src/modules/Unity/Application/session.h'
+ QList<MirSurfaceInterface*> m_blankSurfaces;
What use is this? I only see you append to and remove from this list, but never use it for anything.

+ Q_PROPERTY(MirSurfaceInterface* lastSurface READ lastSurface NOTIFY lastSurfaceChanged CONSTANT);
Can you add a "REMOVEME" comment to this, this is not an API I want to keep. It also not very correct, as what if the surface pointed to is removed, but other surfaces exist - should it not be updated?

review: Needs Fixing

[lp:~dandrader/qtmir/multiSurfaceApp]

364. By Alberto Aguirre on 2015-08-17

Remove protobuf - it is not used anymore.
Approved by: Gerry Boland

365. By CI Train Bot Account on 2015-08-17

Releasing 0.4.5+15.10.20150817-0ubuntu1

366. By CI Train Bot Account on 2015-08-24

Resync trunk.

367. By Daniel d'Andrada on 2015-08-27

Enable multiple MirSurfaceItems rendering the same MirSurface

So MirSurface is the model and MirSurfaceItem is the view+controller.

+ Make MirSurfaceItem instantiable from QML
+ Isolate all mir::scene::Surface code inside MirSurface
+ Enhanced qml-demo-shell: you can now move, resize and *clone* windows
Approved by: Gerry Boland

368. By Daniel d'Andrada on 2015-08-27

Allow resizing an app that is in the process of getting suspended.

Happens when you lock the phone while showing an app in landscape. As
the display turns off, shell rotates itself back to portrait and starts
suspending the app. Fixes: #1466510
Approved by: Gerry Boland

369. By CI Train Bot Account on 2015-08-27

Releasing 0.4.6+15.04.20150827.1-0ubuntu1

370. By Michał Sawicz on 2015-09-04

No-change rebuild to resync vivid+overlay and wily
Approved by: Michael Zanetti

371. By CI Train Bot Account on 2015-09-04

Releasing 0.4.6+15.10.20150904-0ubuntu1

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:372
http://jenkins.qa.ubuntu.com/job/qtmir-ci/411/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/144
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/144/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/411/rebuild

review: Approve (continuous-integration)

[Daniel d'Andrada (dandrader)]

> Please merge trunk, many conflicts have appeared.

Done.

> +void Session::appendSurface
> +void Session::reallyAppendSurface
> these names confuse me. Perhaps rename to something like:
> appendSurface -> registerSurface
> reallyAppendSurface -> appendSurface

Done.

> qDebug() << "Application::suspend - no surface to call stopFrameDropper()
> on!";
> I think we can move this to category logging

Done.

> + return const_cast<ObjectListModel<MirSurfaceInterface>*>(&m_surfaces);
> const_cast needed here? Can't the pointer be a pointer to a const object?

Right. I was just blindly following the signature of childSessions. Fixed.

> === modified file 'src/modules/Unity/Application/session.h'
> + QList<MirSurfaceInterface*> m_blankSurfaces;
> What use is this? I only see you append to and remove from this list, but
> never use it for anything.

Originally it was meant to keep track of the surfaces that were registered but not yet appended. But later it turned out that this wasn't needed after all. Removed.

> + Q_PROPERTY(MirSurfaceInterface* lastSurface READ lastSurface NOTIFY
> lastSurfaceChanged CONSTANT);
> Can you add a "REMOVEME" comment to this, this is not an API I want to keep.
> It also not very correct, as what if the surface pointed to is removed, but
> other surfaces exist - should it not be updated?

This will be removed once unity8 starts using Session.surfaces. Ie, once it actually starts supporting multiple surfaces per application. It was just way too awkward to have untiy8 fetching the last surface from Session.surfaces in QML. Hence this property.

Added the FIXME comment to the property declaration.

lastSurface is being updated correctly as the surfaces model changes.

[lp:~dandrader/qtmir/multiSurfaceApp]

372. By Daniel van Vugt on 2015-09-14

Stop waking up every 200ms if there's nothing to wake up for.
It's just wasting battery.

This solves at least half of LP: #1479250. Although the regular
wakeup problem is solved by this, Unity8 continues to use noticeable
CPU while idle (obviously in much less frequent intervals now). Fixes: #1479250
Approved by: Gerry Boland

373. By Daniel d'Andrada on 2015-09-14

MirSurfaceItem gets dirty when it's set to draw a different (or no) surface Fixes: #1492185
Approved by: Gerry Boland

374. By Daniel d'Andrada on 2015-09-14

QtEventFeeder: log the pointer events it gets from Mir
Approved by: PS Jenkins bot, Gerry Boland

375. By CI Train Bot Account on 2015-09-14

Releasing 0.4.6+15.10.20150914-0ubuntu1

376. By Daniel d'Andrada on 2015-09-18

Update surface focus when a surface enters or leaves a MirSurfaceItem

+ Refactor MirSurfaceItem so that it talks to a MirSurfaceInterface
  instead of the concrete MirSurface class
+ Make MirSurface::setFocus() more robust Fixes: #1491034, #1495437
Approved by: PS Jenkins bot, Gerry Boland

377. By CI Train Bot Account on 2015-09-18

Releasing 0.4.6+15.10.20150918-0ubuntu1

378. By Cemil Azizoglu on 2015-09-23

Port gl_bind_to_texture to the new TextureSource interface.
Update for Mir 0.16 release.
Approved by: Alan Griffiths

379. By CI Train Bot Account on 2015-09-23

Releasing 0.4.6+15.10.20150923-0ubuntu1

380. By Michał Sawicz on 2015-09-25

Bump application API version
Approved by: Daniel d'Andrada

381. By CI Train Bot Account on 2015-09-25

Releasing 0.4.6+15.10.20150925-0ubuntu1

[Gerry Boland (gerboland)]

Code looks ok to me. There's a unity8 change needed to enable this fully though. Could you please link that MP here.

review: Approve (code)

[Daniel d'Andrada (dandrader)]

> Code looks ok to me. There's a unity8 change needed to enable this fully
> though. Could you please link that MP here.

Done

[lp:~dandrader/qtmir/multiSurfaceApp]

382. By Daniel d'Andrada on 2015-09-30

MirSurfaceItem: texture must be manipulated only from the scene graph thread

Do not delete the texture from within the GUI thread ever, even if the
MirSurfaceItem is no longer holding the MirSurface that provided it.
Otherwise you run the risk of having the scene graph thread dereferencing
a pointer to a texture that no longer exists.

This also fixes fd leak LP: #1495871 (which was a texture/buffer leak). Fixes: #1495871, #1499388
Approved by: Gerry Boland, PS Jenkins bot

383. By Gerry Boland on 2015-09-30

Add "Closing" state to Application, use it to distinguish user-induced close from app-induced close. Don't clear QML cache if user-induced.

Much code taken from a partially-related branch by Nick Dedekind:
https://code.launchpad.net/~nick-dedekind/qtmir/polite-close/+merge/262188

Note there is 1 disabled test, which needs additional work to fix. Fixes: #1500372
Approved by: PS Jenkins bot

384. By CI Train Bot Account on 2015-09-30

Releasing 0.4.6+15.10.20150930.1-0ubuntu1

385. By Alexandros Frantzis on 2015-10-08

Update for Mir 0.17 changes

386. By CI Train Bot Account on 2015-10-08

Releasing 0.4.6+15.10.20151008.2-0ubuntu1

387. By Albert Astals Cid on 2015-10-21

Don't search for the element again

Approved by: Gerry Boland, PS Jenkins bot

388. By Daniel d'Andrada on 2015-10-21

Shell draws its own cursor using the new Cursor QML element
Approved by: Lukáš Tinkl, Gerry Boland

389. By Gerry Boland on 2015-10-21

Initial multimonitor support - react correctly to Mir DisplayConfiguration changes.

On Mir DisplayConfiguration changes, QtMir now correctly:
1. blocks Mir until it has stopped all renderers and has their GL contexts released
2. reads the new DisplayConfiguration, matches any existing ScreenWindows to new DisplayBuffers should they change (as Mir may destroy and create it on us)
3. restarts all renderers

This also solves shutdown crash issues due to raciness of mir destroying the GL context backing the shell's QWindow before its renderer had stopped.

Add Unity.Screens qml module to advertise current screen state to QML. Fixes: #1436735, #1488831, #1488863
Approved by: Daniel d'Andrada

390. By Michał Sawicz on 2015-10-21

MirSurfaceItem: Survive holding a surface with an empty texture

Survive having a surface whose texture holds no mir buffer at all.
Instead of crashing in such situation we simply don't render it.
Approved by: Gerry Boland

391. By Michał Sawicz on 2015-10-21

Improve multimonitor support

* Removed magic:
 - Don't automagically select the screen where a window will be show.
   Let shell decide.
 - Don't automagically focus a window. Let shell handle it.

* Let shell know when a screen is about to be removed so that it has
  the opportunity to move or destroy a window in it before it's too late.
  - Added QGuiApplication::onScreenAboutToBeRemoved

* Added logging to key events
Approved by: Michał Sawicz

392. By Alan Griffiths on 2015-10-21

Opaquify MirWindowManager to control visibility of upcoming Window Management work
Approved by: Gerry Boland, PS Jenkins bot

393. By Lukáš Tinkl on 2015-10-21

React to surface modifications (window caption)
Approved by: Daniel d'Andrada

394. By Nick Dedekind on 2015-10-21

Removed the manipulation of the CMAKE_INSTALL_PREFIX from debian/rules
Approved by: Gerry Boland

395. By Nick Dedekind on 2015-10-21

Added touch performance tracing and test.
Approved by: Gerry Boland

396. By Lukáš Tinkl on 2015-10-21

Implement support for mouse wheel events; correctly pass around buttons Fixes: #1497091
Approved by: Gerry Boland

397. By Gerry Boland on 2015-10-21

Workaround for AutoPilot input coordinate positioning being outside screen geometry

398. By CI Train Bot Account on 2015-10-21

Releasing 0.4.6+15.10.20151021-0ubuntu1

[Michael Zanetti (mzanetti)]

I've tested it and it works.

review: Approve (functional testing)

[lp:~dandrader/qtmir/multiSurfaceApp]

399. By Michał Sawicz on 2015-11-02

Clean up packaging and fix autopkgtest on armhf
Approved by: Gerry Boland

400. By Michael Terry on 2015-11-02

Support new isTouchApp property to ApplicationInfoInterface and move lifecycle policy logic out of qtmir.

Now that qtmir won't decide policy for suspending anymore, we don't need all the lifecycleException handling in qtmir either. That can move to unity8.

But since the GSettings key for that was registered under the qtmir namespace (and there's no technical reason to migrate settings), I left the schema and classes dealing with GSettings alone, for future use.

401. By Nick Dedekind on 2015-11-02

Support server->client visibility change to stop rendering (lp:#1475678) Fixes: #1475678
Approved by: Daniel d'Andrada

402. By Alan Griffiths on 2015-11-02

Test harness for MirWindowManager (in preparation for more intelligent window management)
Approved by: Gerry Boland

403. By Nick Dedekind on 2015-11-02

Hand Qt millisecond timestamps rather than nanosecond. Fixes: #1510571, #1511076, #1511711
Approved by: Gerry Boland

404. By CI Train Bot Account on 2015-11-02

Releasing 0.4.6+16.04.20151102-0ubuntu1

405. By Nick Dedekind on 2015-11-10

Reverted occlusion detection (lp#1514556) Fixes: #1514556

406. By CI Train Bot Account on 2015-11-10

Releasing 0.4.6+16.04.20151110-0ubuntu1

407. By Gerry Boland on 2015-11-12

Fix armhf builds on Xenial by using -std=gnu99 instead of c99

Fixes this FTBFS on xenial:

In file included from /usr/include/lttng/tracepoint-rcu.h:26:0,
                 from /usr/include/lttng/tracepoint.h:29,
                 from /home/phablet/dev/projects/qtmir/qtmir/BUILD-xen/src/platforms/mirserver/tracepoints.h:10,
                 from /home/phablet/dev/projects/qtmir/qtmir/BUILD-xen/src/platforms/mirserver/tracepoints.c:7:
/usr/include/urcu/arch/generic.h: In function ‘caa_get_cycles’:
/usr/include/urcu/arch/generic.h:165:6: error: ‘CLOCK_MONOTONIC’ undeclared (first use in this function)
  if (caa_unlikely(clock_gettime(CLOCK_MONOTONIC, &ts)))
      ^
/usr/include/urcu/arch/generic.h:165:6: note: each undeclared identifier is reported only once for each function it appears in

Strictly should compile code with -std=gnu99 instead of -std=c99 to have the identifiers SIGEV_SIGNAL, sigeventStruct, and CLOCK_MONOTONIC available. These identifiers are declared when _POSIX_C_SOURCE is set to a value >= 199309L, which is the case with -std=gnu99. I could also have used -D_POSIX_C_SOURCE=199309L -std=c99 or have the macro defined in source code.

Did not impact wily as libuctu only started looking for CLOCK_MONOTONIC in Xenial release.
Approved by: Daniel d'Andrada

408. By CI Train Bot Account on 2015-11-12

Releasing 0.4.6+16.04.20151112-0ubuntu1

409. By Nick Dedekind on 2015-11-13

Update surface textures when dropping frames. Fixes: #1515356
Approved by: Gerry Boland

410. By CI Train Bot Account on 2015-11-13

Releasing 0.4.6+16.04.20151113-0ubuntu1

411. By Gerry Boland on 2015-11-19

Fix use of uninitialized variable
Approved by: Daniel d'Andrada, PS Jenkins bot

412. By Albert Astals Cid on 2015-11-19

Enable Efficient String Construction by default

See http://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/
Approved by: Gerry Boland, PS Jenkins bot

413. By Michał Sawicz on 2015-11-19

Build with clang (tests/gmock fails and is unfixable on our side i'd say)
Approved by: Gerry Boland

414. By Gerry Boland on 2015-11-19

Use pid_t for PIDs.
Approved by: Daniel d'Andrada, PS Jenkins bot

415. By Loïc Molinari on 2015-11-19

Ensured Mir surface items with size less than or equal to zero are not rendered, as it's usually done for standard QtQuick items.
Approved by: Gerry Boland

416. By Nick Dedekind on 2015-11-19

Fix a crash when dropping a surface frame before Qt draws a surface item. Fixes: #1517139
Approved by: Gerry Boland

417. By CI Train Bot Account on 2015-11-19

Releasing 0.4.6+16.04.20151119-0ubuntu1

418. By Daniel d'Andrada on 2015-11-25

Implemented support for cursors set by client surfaces
Approved by: Lukáš Tinkl

419. By Gerry Boland on 2015-11-25

Manage frameSwapped signal/slot connection with MirSurface more strictly to avoid crash.

Direct Signal/slot connections across thread boundaries incur the same risks as any cross-thread calls. While connect/disconnect are thread safe methods, it is possible for a slot to be called while the slot owner is being deconstructed - and so not yet disconnected.

So watch for the Item's window change signal and disconnect signal immediately. Also move slot ownership to MirSurfaceItem to auto-disconnect more aggressively.
 Fixes: #1517571
Approved by: Daniel d'Andrada

420. By Daniel d'Andrada on 2015-11-25

Forward Mir mouse wheel events to the shell cursor Fixes: #1497091
Approved by: Lukáš Tinkl

421. By Daniel d'Andrada on 2015-11-25

Revert revision 415

The commit "Ensured Mir surface items with size less than or equal to zero are not rendered,
as it's usually done for standard QtQuick items." caused a regression.

MirSurface.size was being kept uninitialized, as QSize(-1,-1).

422. By CI Train Bot Account on 2015-11-25

Releasing 0.4.6+16.04.20151125-0ubuntu1

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:419
http://jenkins.qa.ubuntu.com/job/qtmir-ci/581/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/277
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/277
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/277/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/159
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/159/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/581/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:424
http://jenkins.qa.ubuntu.com/job/qtmir-ci/587/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/283/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/283/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/165/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/320/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/320/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/165/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/587/rebuild

review: Needs Fixing (continuous-integration)

[lp:~dandrader/qtmir/multiSurfaceApp]

423. By Timo Jyrinki on 2015-12-01

Rebuild against Qt 5.5.1.

424. By Daniel d'Andrada on 2015-12-04

Merge lp:~dandrader/qtmir/surfaceItemFillMode

425. By Daniel d'Andrada on 2015-12-04

Make Session hold multiple surfaces

+ Standardize MirSurface debug messages and account for multiple surfaces per app

426. By Daniel d'Andrada on 2015-12-04

Merge surfaceItemFillMode again

427. By Daniel d'Andrada on 2015-12-04

Fix bad merge with polite-close

Unmerged revisions

427. By Daniel d'Andrada on 2015-12-04

Fix bad merge with polite-close

426. By Daniel d'Andrada on 2015-12-04

Merge surfaceItemFillMode again

425. By Daniel d'Andrada on 2015-12-04

Make Session hold multiple surfaces

+ Standardize MirSurface debug messages and account for multiple surfaces per app

424. By Daniel d'Andrada on 2015-12-04

Merge lp:~dandrader/qtmir/surfaceItemFillMode

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-11-25 15:38:50 +0000
+++ CMakeLists.txt	2015-12-01 12:47:17 +0000
@@ -75,7 +75,7 @@
 pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
 pkg_check_modules(QTDBUSTEST libqtdbustest-1 REQUIRED)
 pkg_check_modules(QTDBUSMOCK libqtdbusmock-1 REQUIRED)
-pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=11)
+pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=12)
 
 include_directories(${APPLICATION_API_INCLUDE_DIRS})
 
 
=== modified file 'debian/control'
--- debian/control	2015-11-25 15:38:50 +0000
+++ debian/control	2015-12-01 12:47:17 +0000
@@ -22,7 +22,7 @@
                libubuntu-app-launch2-dev,
                libubuntu-application-api-dev (>= 2.1.0),
                libudev-dev,
-               libunity-api-dev (>= 7.103),
+               libunity-api-dev (>= 7.104),
                liburl-dispatcher1-dev,
                libxkbcommon-dev,
                libxrender-dev,
@@ -93,7 +93,7 @@
 Conflicts: libqtmir,
            libunity-mir1,
 Provides: unity-application-impl,
-          unity-application-impl-11,
+          unity-application-impl-12,
 Description: Qt plugin for Unity specific Mir APIs
  QtMir provides Qt/QML bindings for Mir features that are exposed through the
  qtmir-desktop or qtmir-android QPA plugin such as Application management
 
=== modified file 'src/modules/Unity/Application/mirbuffersgtexture.cpp'
--- src/modules/Unity/Application/mirbuffersgtexture.cpp	2015-10-02 12:20:00 +0000
+++ src/modules/Unity/Application/mirbuffersgtexture.cpp	2015-12-01 12:47:17 +0000
@@ -21,6 +21,9 @@
 #include <mir/geometry/size.h>
 #include <mir/renderer/gl/texture_source.h>
 
+// mirserver
+#include <logging.h>
+
 namespace mg = mir::geometry;
 namespace mrg = mir::renderer::gl;
 
@@ -80,20 +83,25 @@
         return m_mirBuffer->pixel_format() == mir_pixel_format_abgr_8888
             || m_mirBuffer->pixel_format() == mir_pixel_format_argb_8888;
     } else {
+        qCWarning(QTMIR_SURFACES) << "MirBufferSGTexture: hasAlphaChannel() called but there's no mir buffer to query";
         return false;
     }
 }
 
 void MirBufferSGTexture::bind()
 {
-    Q_ASSERT(hasBuffer());
-    glBindTexture(GL_TEXTURE_2D, m_textureId);
-    updateBindOptions(true/* force */);
-
-    auto const texture_source =
-        dynamic_cast<mrg::TextureSource*>(m_mirBuffer->native_buffer_base());
-    if (!texture_source)
-        throw std::logic_error("Buffer does not support GL rendering");
-
-    texture_source->gl_bind_to_texture();
+    if (hasBuffer()) {
+        glBindTexture(GL_TEXTURE_2D, m_textureId);
+        updateBindOptions(true/* force */);
+
+        auto const texture_source =
+            dynamic_cast<mrg::TextureSource*>(m_mirBuffer->native_buffer_base());
+        if (!texture_source)
+            throw std::logic_error("Buffer does not support GL rendering");
+
+        texture_source->gl_bind_to_texture();
+    } else {
+        qCWarning(QTMIR_SURFACES) << "MirBufferSGTexture: bind() called but there's no mir buffer to bind to";
+        glBindTexture(GL_TEXTURE_2D, 0);
+    }
 }
 
=== modified file 'src/modules/Unity/Application/mirsurface.cpp'
--- src/modules/Unity/Application/mirsurface.cpp	2015-11-25 15:38:39 +0000
+++ src/modules/Unity/Application/mirsurface.cpp	2015-12-01 12:47:17 +0000
@@ -25,6 +25,7 @@
 
 // Mir
 #include <mir/geometry/rectangle.h>
+#include <mir/graphics/buffer.h>
 #include <mir/events/event_builders.h>
 #include <mir/shell/shell.h>
 #include <mir_toolkit/event.h>
@@ -34,6 +35,8 @@
 
 using namespace qtmir;
 
+#define DEBUG_MSG qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << (void*)this << "," << appId() <<"]::" << __func__
+
 namespace {
 
 // Would be better if QMouseEvent had nativeModifiers
@@ -216,7 +219,7 @@
     Q_ASSERT(m_views.isEmpty());
 
     if (m_session) {
-        m_session->setSurface(nullptr);
+        m_session->removeSurface(this);
     }
 
     QMutexLocker locker(&m_mutex);
@@ -297,15 +300,14 @@
     int framesPending = m_surface->buffers_ready_for_compositor(userId);
     if (framesPending > 0) {
         m_textureUpdated = false;
-        
+
         locker.unlock();
         if (updateTexture()) {
-            qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::dropPendingBuffer() dropped=1 left=" << framesPending-1;
+            DEBUG_MSG << "() dropped=1 left=" << framesPending-1;
         } else {
             // If we haven't managed to update the texture, don't keep banging away.
             m_frameDropperTimer.stop();
-            qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::dropPendingBuffer() dropped=0"
-                                              << " left=" << framesPending << " - failed to upate texture";
+            DEBUG_MSG << "() dropped=0" << " left=" << framesPending << " - failed to upate texture";
         }
         Q_EMIT frameDropped();
     } else {
@@ -319,13 +321,13 @@
 
 void MirSurface::stopFrameDropper()
 {
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::stopFrameDropper()";
+    DEBUG_MSG << "()";
     m_frameDropperTimer.stop();
 }
 
 void MirSurface::startFrameDropper()
 {
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::startFrameDropper()";
+    DEBUG_MSG << "()";
     if (!m_frameDropperTimer.isActive()) {
         m_frameDropperTimer.start();
     }
@@ -355,39 +357,53 @@
         return texture->hasBuffer();
     }
 
-    const void* const userId = (void*)123;
-    auto renderables = m_surface->generate_renderables(userId);
-
-    if (renderables.size() > 0 &&
-            (m_surface->buffers_ready_for_compositor(userId) > 0 || !texture->hasBuffer())
-        ) {
+    if (m_pendingBuffer) {
         // Avoid holding two buffers for the compositor at the same time. Thus free the current
         // before acquiring the next
         texture->freeBuffer();
-        texture->setBuffer(renderables[0]->buffer());
+        texture->setBuffer(m_pendingBuffer);
+        m_pendingBuffer.reset();
         ++m_currentFrameNumber;
-
-        if (texture->textureSize() != m_size) {
-            m_size = texture->textureSize();
-            QMetaObject::invokeMethod(this, "emitSizeChanged", Qt::QueuedConnection);
+    }
+
+    m_textureUpdated = true;
+
+    return texture->hasBuffer();
+}
+
+void MirSurface::consumeBuffer()
+{
+    QMutexLocker locker(&m_mutex);
+    const void* const userId = (void*)123;
+    auto renderables = m_surface->generate_renderables(userId);
+
+    if (renderables.size() > 0 && m_surface->buffers_ready_for_compositor(userId) > 0) {
+        m_pendingBuffer = renderables[0]->buffer();
+
+        QSize size(m_pendingBuffer->size().width.as_int(),
+                   m_pendingBuffer->size().height.as_int());
+        if (size != m_size) {
+            m_size = size;
+            Q_EMIT sizeChanged(m_size);
         }
-
-        m_textureUpdated = true;
     }
 
     if (m_surface->buffers_ready_for_compositor(userId) > 0) {
         // restart the frame dropper to give MirSurfaceItems enough time to render the next frame.
-        // queued since the timer lives in a different thread
-        QMetaObject::invokeMethod(&m_frameDropperTimer, "start", Qt::QueuedConnection);
+        QMetaObject::invokeMethod(&m_frameDropperTimer, "start", Qt::AutoConnection);
     }
-
-    return texture->hasBuffer();
 }
 
 void MirSurface::onCompositorSwappedBuffers()
 {
     QMutexLocker locker(&m_mutex);
     m_textureUpdated = false;
+
+    if (m_texture && m_pendingBuffer) {
+        // No need to hold onto this buffer as it won't be used on the next frame.
+        MirBufferSGTexture *texture = static_cast<MirBufferSGTexture*>(m_texture.data());
+        texture->freeBuffer();
+    }
 }
 
 bool MirSurface::numBuffersReadyForCompositor()
@@ -406,12 +422,11 @@
     // Temporary hotfix for http://pad.lv/1483752
     if (m_session->childSessions()->rowCount() > 0) {
         // has child trusted session, ignore any focus change attempts
-        qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::setFocus(" << focus
-            << ") - has child trusted session, ignore any focus change attempts";
+        DEBUG_MSG << "(" << focus << ") - has child trusted session, ignore any focus change attempts";
         return;
     }
 
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::setFocus(" << focus << ")";
+    DEBUG_MSG << "(" << focus << ")";
 
     if (focus) {
         m_shell->set_surface_attribute(m_session->session(), m_surface, mir_surface_attrib_focus, mir_surface_focused);
@@ -430,9 +445,8 @@
     if (clientIsRunning() && mirSizeIsDifferent) {
         mir::geometry::Size newMirSize(width, height);
         m_surface->resize(newMirSize);
-        qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::resize"
-                << " old (" << mirWidth << "," << mirHeight << ")"
-                << ", new (" << width << "," << height << ")";
+        DEBUG_MSG << " old (" << mirWidth << "," << mirHeight << ")"
+                  << ", new (" << width << "," << height << ")";
     }
 }
 
@@ -659,8 +673,7 @@
 void MirSurface::registerView(qintptr viewId)
 {
     m_views.insert(viewId, MirSurface::View{false});
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::registerView(" << viewId << ")"
-                                      << " after=" << m_views.count();
+    DEBUG_MSG << "(" << viewId << ")" << " after=" << m_views.count();
     if (m_views.count() == 1) {
         Q_EMIT isBeingDisplayedChanged();
     }
@@ -668,9 +681,8 @@
 
 void MirSurface::unregisterView(qintptr viewId)
 {
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::unregisterView(" << viewId << ")"
-                                      << " after=" << m_views.count() << " live=" << m_live;
     m_views.remove(viewId);
+    DEBUG_MSG << "(" << viewId << ")" << " after=" << m_views.count() << " live=" << m_live;
     if (m_views.count() == 0) {
         Q_EMIT isBeingDisplayedChanged();
         if (m_session.isNull() || !m_live) {
@@ -701,7 +713,7 @@
     }
 
     if (newVisible != visible()) {
-        qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::updateVisibility(" << newVisible << ")";
+        DEBUG_MSG << "(" << newVisible << ")";
 
         m_surface->configure(mir_surface_attrib_visibility,
                              newVisible ? mir_surface_visibility_exposed : mir_surface_visibility_occluded);
@@ -745,8 +757,7 @@
 
 void MirSurface::setCursor(const QCursor &cursor)
 {
-    qCDebug(QTMIR_SURFACES).nospace() << "MirSurface[" << appId() << "]::setCursor("
-        << qtCursorShapeToStr(cursor.shape()) << ")";
+    DEBUG_MSG << "(" << qtCursorShapeToStr(cursor.shape()) << ")";
 
     m_cursor = cursor;
     Q_EMIT cursorChanged(m_cursor);
 
=== modified file 'src/modules/Unity/Application/mirsurface.h'
--- src/modules/Unity/Application/mirsurface.h	2015-11-25 15:38:39 +0000
+++ src/modules/Unity/Application/mirsurface.h	2015-12-01 12:47:17 +0000
@@ -35,7 +35,10 @@
 #include <mir/scene/surface.h>
 #include <mir_toolkit/common.h>
 
-namespace mir { namespace shell { class Shell; }}
+namespace mir {
+    namespace shell { class Shell; }
+    namespace graphics { class Buffer; }
+}
 
 class SurfaceObserver;
 
@@ -89,6 +92,8 @@
     void unregisterView(qintptr viewId) override;
     void setViewVisibility(qintptr viewId, bool visible) override;
 
+    void consumeBuffer() override;
+
     // methods called from the rendering (scene graph) thread:
     QSharedPointer<QSGTexture> texture() override;
     QSGTexture *weakTexture() const override { return m_texture.data(); }
@@ -120,7 +125,9 @@
     QCursor cursor() const override;
 
 public Q_SLOTS:
+    // methods called from the rendering (scene graph) thread:
     void onCompositorSwappedBuffers() override;
+    // end of methods called from the rendering (scene graph) thread
 
 private Q_SLOTS:
     void dropPendingBuffer();
@@ -163,6 +170,8 @@
     QSize m_size;
 
     QCursor m_cursor;
+
+    std::shared_ptr<mir::graphics::Buffer> m_pendingBuffer;
 };
 
 } // namespace qtmir
 
=== modified file 'src/modules/Unity/Application/mirsurfaceinterface.h'
--- src/modules/Unity/Application/mirsurfaceinterface.h	2015-11-25 15:38:39 +0000
+++ src/modules/Unity/Application/mirsurfaceinterface.h	2015-12-01 12:47:17 +0000
@@ -54,6 +54,8 @@
     virtual void unregisterView(qintptr viewId) = 0;
     virtual void setViewVisibility(qintptr viewId, bool visible) = 0;
 
+    virtual void consumeBuffer() = 0;
+
     // methods called from the rendering (scene graph) thread:
     virtual QSharedPointer<QSGTexture> texture() = 0;
     virtual QSGTexture *weakTexture() const = 0;
@@ -88,7 +90,9 @@
     void cursorChanged(const QCursor &cursor);
 
 public Q_SLOTS:
+    // methods called from the rendering (scene graph) thread:
     virtual void onCompositorSwappedBuffers() = 0;
+    // end of methods called from the rendering (scene graph) thread
 
 Q_SIGNALS:
     void firstFrameDrawn();
 
=== modified file 'src/modules/Unity/Application/mirsurfaceitem.cpp'
--- src/modules/Unity/Application/mirsurfaceitem.cpp	2015-11-25 15:38:54 +0000
+++ src/modules/Unity/Application/mirsurfaceitem.cpp	2015-12-01 12:47:17 +0000
@@ -92,6 +92,7 @@
     , m_surfaceHeight(0)
     , m_orientationAngle(nullptr)
     , m_consumesInput(false)
+    , m_fillMode(Stretch)
 {
     qCDebug(QTMIR_SURFACES) << "MirSurfaceItem::MirSurfaceItem";
 
@@ -227,7 +228,7 @@
     }
 
     if (m_surface->numBuffersReadyForCompositor() > 0) {
-        QTimer::singleShot(0, this, SLOT(update()));
+        QTimer::singleShot(0, this, SLOT(polishAndUpdate()));
     }
 
     m_textureProvider->smooth = smooth();
@@ -235,20 +236,35 @@
     QSGDefaultImageNode *node = static_cast<QSGDefaultImageNode*>(oldNode);
     if (!node) {
         node = new QSGDefaultImageNode;
-        node->setTexture(m_textureProvider->texture());
-
         node->setMipmapFiltering(QSGTexture::None);
         node->setHorizontalWrapMode(QSGTexture::ClampToEdge);
         node->setVerticalWrapMode(QSGTexture::ClampToEdge);
-        node->setSubSourceRect(QRectF(0, 0, 1, 1));
     } else {
         if (!m_lastFrameNumberRendered  || (*m_lastFrameNumberRendered != m_surface->currentFrameNumber())) {
             node->markDirty(QSGNode::DirtyMaterial);
         }
     }
-
-    node->setTargetRect(QRectF(0, 0, width(), height()));
-    node->setInnerTargetRect(QRectF(0, 0, width(), height()));
+    node->setTexture(m_textureProvider->texture());
+
+    if (m_fillMode == PadOrCrop) {
+        const QSize &textureSize = m_textureProvider->texture()->textureSize();
+
+        QRectF targetRect;
+        targetRect.setWidth(qMin(width(), static_cast<qreal>(textureSize.width())));
+        targetRect.setHeight(qMin(height(), static_cast<qreal>(textureSize.height())));
+
+        qreal u = targetRect.width() / textureSize.width();
+        qreal v = targetRect.height() / textureSize.height();
+        node->setSubSourceRect(QRectF(0, 0, u, v));
+
+        node->setTargetRect(targetRect);
+        node->setInnerTargetRect(targetRect);
+    } else {
+        // Stretch
+        node->setSubSourceRect(QRectF(0, 0, 1, 1));
+        node->setTargetRect(QRectF(0, 0, width(), height()));
+        node->setInnerTargetRect(QRectF(0, 0, width(), height()));
+    }
 
     node->setFiltering(smooth() ? QSGTexture::Linear : QSGTexture::Nearest);
     node->setAntialiasing(antialiasing());
@@ -626,7 +642,7 @@
 
         // When a new mir frame gets posted we notify the QML engine that this item needs redrawing,
         // schedules call to updatePaintNode() from the rendering thread
-        connect(m_surface, &MirSurfaceInterface::framesPosted, this, &QQuickItem::update);
+        connect(m_surface, &MirSurfaceInterface::framesPosted, this, &MirSurfaceItem::polishAndUpdate);
 
         connect(m_surface, &MirSurfaceInterface::stateChanged, this, &MirSurfaceItem::surfaceStateChanged);
         connect(m_surface, &MirSurfaceInterface::liveChanged, this, &MirSurfaceItem::liveChanged);
@@ -730,6 +746,33 @@
     }
 }
 
+MirSurfaceItem::FillMode MirSurfaceItem::fillMode() const
+{
+    return m_fillMode;
+}
+
+void MirSurfaceItem::setFillMode(FillMode value)
+{
+    if (m_fillMode != value) {
+        m_fillMode = value;
+        Q_EMIT fillModeChanged(m_fillMode);
+    }
+}
+
+void MirSurfaceItem::polishAndUpdate()
+{
+    polish();
+    update();
+}
+
+void MirSurfaceItem::updatePolish()
+{
+    if (!m_surface || !m_surface->live()) {
+        return;
+    }
+    m_surface->consumeBuffer();
+}
+
 } // namespace qtmir
 
 #include "mirsurfaceitem.moc"
 
=== modified file 'src/modules/Unity/Application/mirsurfaceitem.h'
--- src/modules/Unity/Application/mirsurfaceitem.h	2015-11-25 15:38:44 +0000
+++ src/modules/Unity/Application/mirsurfaceitem.h	2015-12-01 12:47:17 +0000
@@ -68,6 +68,9 @@
     int surfaceHeight() const override;
     void setSurfaceHeight(int value) override;
 
+    FillMode fillMode() const override;
+    void setFillMode(FillMode value) override;
+
     ////////
     // QQuickItem
 
@@ -107,6 +110,8 @@
 
     void releaseResources() override;
 
+    void updatePolish() override;
+
 private Q_SLOTS:
     void scheduleMirSurfaceSizeUpdate();
     void updateMirSurfaceSize();
@@ -119,6 +124,8 @@
 
     void onWindowChanged(QQuickWindow *window);
 
+    void polishAndUpdate();
+
 private:
     void ensureTextureProvider();
 
@@ -168,6 +175,8 @@
     Mir::OrientationAngle *m_orientationAngle;
 
     bool m_consumesInput;
+
+    FillMode m_fillMode;
 };
 
 } // namespace qtmir
 
=== modified file 'src/modules/Unity/Application/mirsurfacemanager.cpp'
--- src/modules/Unity/Application/mirsurfacemanager.cpp	2015-10-09 15:35:05 +0000
+++ src/modules/Unity/Application/mirsurfacemanager.cpp	2015-12-01 12:47:17 +0000
@@ -110,7 +110,7 @@
     }
 
     if (session)
-        session->setSurface(qmlSurface);
+        session->registerSurface(qmlSurface);
 
     // Only notify QML of surface creation once it has drawn its first frame.
     connect(qmlSurface, &MirSurfaceInterface::firstFrameDrawn, this, [=]() {
 
=== modified file 'src/modules/Unity/Application/session.cpp'
--- src/modules/Unity/Application/session.cpp	2015-08-31 09:51:28 +0000
+++ src/modules/Unity/Application/session.cpp	2015-12-01 12:47:17 +0000
@@ -46,7 +46,6 @@
     : SessionInterface(parent)
     , m_session(session)
     , m_application(nullptr)
-    , m_surface(nullptr)
     , m_parentSession(nullptr)
     , m_children(new SessionModel(this))
     , m_fullscreen(false)
@@ -86,10 +85,15 @@
 void Session::doSuspend()
 {
     Q_ASSERT(m_state == Session::Suspending);
-    if (m_surface) {
-        m_surface->stopFrameDropper();
+
+
+    auto surfaceList = m_surfaces.list();
+    if (surfaceList.empty()) {
+        qCDebug(QTMIR_SESSIONS) << "Application::suspend - no surface to call stopFrameDropper() on!";
     } else {
-        qDebug() << "Application::suspend - no surface to call stopFrameDropper() on!";
+        for (int i = 0; i < surfaceList.count(); ++i) {
+            surfaceList[i]->stopFrameDropper();
+        }
     }
     setState(Suspended);
 }
@@ -120,14 +124,9 @@
     return m_application;
 }
 
-MirSurfaceInterface* Session::surface() const
+const ObjectListModel<MirSurfaceInterface>* Session::surfaces() const
 {
-    // Only notify QML of surface creation once it has drawn its first frame.
-    if (m_surface && m_surface->isFirstFrameDrawn()) {
-        return m_surface;
-    } else {
-        return nullptr;
-    }
+    return &m_surfaces;
 }
 
 SessionInterface* Session::parentSession() const
@@ -166,55 +165,57 @@
     Q_EMIT applicationChanged(application);
 }
 
-void Session::setSurface(MirSurfaceInterface *newSurface)
+void Session::registerSurface(MirSurfaceInterface *newSurface)
 {
-    qCDebug(QTMIR_SESSIONS) << "Session::setSurface - session=" << name() << "surface=" << newSurface;
-
-    if (newSurface == m_surface) {
-        return;
-    }
-
-    if (m_surface) {
-        m_surface->disconnect(this);
-    }
-
-    MirSurfaceInterface *previousSurface = surface();
-    m_surface = newSurface;
-
-    if (newSurface) {
-        connect(newSurface, &MirSurfaceInterface::stateChanged,
-            this, &Session::updateFullscreenProperty);
-
-        // Only notify QML of surface creation once it has drawn its first frame.
-        if (m_surface->isFirstFrameDrawn()) {
-            setState(Running);
-        } else {
-            connect(newSurface, &MirSurfaceInterface::firstFrameDrawn,
-                    this, &Session::onFirstSurfaceFrameDrawn);
-        }
-    }
-
-    if (previousSurface != surface()) {
-        qCDebug(QTMIR_SESSIONS).nospace() << "Session::surfaceChanged - session=" << this
-            << " surface=" << m_surface;
-        Q_EMIT surfaceChanged(m_surface);
+    qCDebug(QTMIR_SESSIONS) << "Session::resgisterSurface - session=" << name() << "surface=" << newSurface;
+
+    // Only notify QML of surface creation once it has drawn its first frame.
+    if (newSurface->isFirstFrameDrawn()) {
+        appendSurface(newSurface);
+    } else {
+        connect(newSurface, &MirSurfaceInterface::firstFrameDrawn,
+                this, [this, newSurface]() { this->appendSurface(newSurface); });
     }
 
     updateFullscreenProperty();
 }
 
-void Session::onFirstSurfaceFrameDrawn()
-{
-    qCDebug(QTMIR_SESSIONS).nospace() << "Session::surfaceChanged - session=" << this
-        << " surface=" << m_surface;
-    Q_EMIT surfaceChanged(m_surface);
-    setState(Running);
+void Session::appendSurface(MirSurfaceInterface *newSurface)
+{
+    qCDebug(QTMIR_SESSIONS) << "Session::appendSurface - session=" << name() << "surface=" << newSurface;
+
+    connect(newSurface, &MirSurfaceInterface::stateChanged,
+        this, &Session::updateFullscreenProperty);
+
+    m_surfaces.insert(m_surfaces.rowCount(), newSurface);
+
+    Q_EMIT lastSurfaceChanged(newSurface);
+
+    if (m_state == Starting) {
+        setState(Running);
+    }
+}
+
+void Session::removeSurface(MirSurfaceInterface* surface)
+{
+    qCDebug(QTMIR_SESSIONS) << "Session::removeSurface - session=" << name() << "surface=" << surface;
+
+    surface->disconnect(this);
+
+    if (m_surfaces.contains(surface)) {
+        bool lastSurfaceWasRemoved = lastSurface() == surface;
+        m_surfaces.remove(surface);
+        if (lastSurfaceWasRemoved) {
+            Q_EMIT lastSurfaceChanged(lastSurface());
+        }
+    }
 }
 
 void Session::updateFullscreenProperty()
 {
-    if (m_surface) {
-        setFullscreen(m_surface->state() == Mir::FullscreenState);
+    if (m_surfaces.rowCount() > 0) {
+        // TODO: Figure out something better
+        setFullscreen(m_surfaces.list().at(0)->state() == Mir::FullscreenState);
     } else {
         // Keep the current value of the fullscreen property until we get a new
         // surface
@@ -264,8 +265,11 @@
         Q_ASSERT(m_suspendTimer->isActive());
         m_suspendTimer->stop();
     } else if (m_state == Suspended) {
-        Q_ASSERT(m_surface);
-        m_surface->startFrameDropper();
+        Q_ASSERT(m_surfaces.rowCount() > 0);
+        auto surfaceList = m_surfaces.list();
+        for (int i = 0; i < surfaceList.count(); ++i) {
+            surfaceList[i]->startFrameDropper();
+        }
     }
 
     session()->set_lifecycle_state(mir_lifecycle_state_resumed);
@@ -285,10 +289,16 @@
 {
     if (m_state != Stopped) {
         stopPromptSessions();
+
         if (m_suspendTimer->isActive())
             m_suspendTimer->stop();
-        if (m_surface)
-            m_surface->stopFrameDropper();
+
+        {
+            auto surfaceList = m_surfaces.list();
+            for (int i = 0; i < surfaceList.count(); ++i) {
+                surfaceList[i]->stopFrameDropper();
+            }
+        }
 
         foreachChildSession([](SessionInterface* session) {
             session->stop();
@@ -422,4 +432,13 @@
     }
 }
 
+MirSurfaceInterface* Session::lastSurface() const
+{
+    if (m_surfaces.rowCount() > 0) {
+        return m_surfaces.list().last();
+    } else {
+        return nullptr;
+    }
+}
+
 } // namespace qtmir
 
=== modified file 'src/modules/Unity/Application/session.h'
--- src/modules/Unity/Application/session.h	2015-08-31 09:51:28 +0000
+++ src/modules/Unity/Application/session.h	2015-12-01 12:47:17 +0000
@@ -52,14 +52,17 @@
     //getters
     QString name() const override;
     unity::shell::application::ApplicationInfoInterface* application() const override;
-    MirSurfaceInterface* surface() const override;
+    MirSurfaceInterface* lastSurface() const override;
+    const ObjectListModel<MirSurfaceInterface>* surfaces() const override;
     SessionInterface* parentSession() const override;
     State state() const override;
     bool fullscreen() const override;
     bool live() const override;
 
     void setApplication(unity::shell::application::ApplicationInfoInterface* item) override;
-    void setSurface(MirSurfaceInterface* surface) override;
+
+    void registerSurface(MirSurfaceInterface* surface) override;
+    void removeSurface(MirSurfaceInterface* surface) override;
 
     void suspend() override;
     void resume() override;
@@ -88,7 +91,6 @@
 
 private Q_SLOTS:
     void updateFullscreenProperty();
-    void onFirstSurfaceFrameDrawn();
 
 private:
     void setParentSession(Session* session);
@@ -97,9 +99,11 @@
 
     void stopPromptSessions();
 
+    void appendSurface(MirSurfaceInterface* surface);
+
     std::shared_ptr<mir::scene::Session> m_session;
     Application* m_application;
-    MirSurfaceInterface* m_surface;
+    ObjectListModel<MirSurfaceInterface> m_surfaces;
     SessionInterface* m_parentSession;
     SessionModel* m_children;
     bool m_fullscreen;
 
=== modified file 'src/modules/Unity/Application/session_interface.h'
--- src/modules/Unity/Application/session_interface.h	2015-08-31 09:51:28 +0000
+++ src/modules/Unity/Application/session_interface.h	2015-12-01 12:47:17 +0000
@@ -24,8 +24,12 @@
 #include <unity/shell/application/ApplicationInfoInterface.h>
 
 // local
+#include "objectlistmodel.h"
 #include "sessionmodel.h"
 
+// Qt
+#include <QQmlListProperty>
+
 namespace mir {
     namespace scene {
         class Session;
@@ -39,7 +43,12 @@
 
 class SessionInterface : public QObject {
     Q_OBJECT
-    Q_PROPERTY(MirSurfaceInterface* surface READ surface NOTIFY surfaceChanged)
+
+    // FIXME: Remove this once unity8 starts trully supporting multiple surfaces per applicaton.
+    //        Ie, remove this once untiy8 moves from using this property to using the surfaces one.
+    Q_PROPERTY(MirSurfaceInterface* lastSurface READ lastSurface NOTIFY lastSurfaceChanged);
+
+    Q_PROPERTY(const ObjectListModel<MirSurfaceInterface>* surfaces READ surfaces CONSTANT);
     Q_PROPERTY(unity::shell::application::ApplicationInfoInterface* application READ application NOTIFY applicationChanged DESIGNABLE false)
     Q_PROPERTY(SessionInterface* parentSession READ parentSession NOTIFY parentSessionChanged DESIGNABLE false)
     Q_PROPERTY(SessionModel* childSessions READ childSessions DESIGNABLE false CONSTANT)
@@ -62,7 +71,8 @@
     //getters
     virtual QString name() const = 0;
     virtual unity::shell::application::ApplicationInfoInterface* application() const = 0;
-    virtual MirSurfaceInterface* surface() const = 0;
+    virtual MirSurfaceInterface* lastSurface() const = 0;
+    virtual const ObjectListModel<MirSurfaceInterface>* surfaces() const = 0;
     virtual SessionInterface* parentSession() const = 0;
     virtual SessionModel* childSessions() const = 0;
     virtual State state() const = 0;
@@ -73,7 +83,8 @@
 
     // For MirSurface and MirSurfaceManager use
 
-    virtual void setSurface(MirSurfaceInterface* surface) = 0;
+    virtual void registerSurface(MirSurfaceInterface* surface) = 0;
+    virtual void removeSurface(MirSurfaceInterface* surface) = 0;
 
     // For Application use
 
@@ -98,16 +109,17 @@
     virtual void removePromptSession(const std::shared_ptr<mir::scene::PromptSession>& session) = 0;
 
 Q_SIGNALS:
-    void surfaceChanged(MirSurfaceInterface*);
     void parentSessionChanged(SessionInterface*);
     void applicationChanged(unity::shell::application::ApplicationInfoInterface* application);
     void stateChanged(State state);
     void fullscreenChanged(bool fullscreen);
     void liveChanged(bool live);
+    void lastSurfaceChanged(MirSurfaceInterface* surface);
 };
 
 } // namespace qtmir
 
 Q_DECLARE_METATYPE(qtmir::SessionInterface*)
+Q_DECLARE_METATYPE(qtmir::ObjectListModel<qtmir::MirSurfaceInterface>*)
 
 #endif // SESSION_INTERFACE_H
 
=== modified file 'tests/modules/ApplicationManager/application_manager_test.cpp'
--- tests/modules/ApplicationManager/application_manager_test.cpp	2015-11-17 14:16:22 +0000
+++ tests/modules/ApplicationManager/application_manager_test.cpp	2015-12-01 12:47:17 +0000
@@ -50,7 +50,7 @@
 
         SessionInterface* qmlSession = sessionManager.findSession(mirSession);
         if (qmlSession) {
-            qmlSession->setSurface(qmlSurface);
+            qmlSession->registerSurface(qmlSurface);
         }
 
         // I assume that applicationManager ignores the mirSurface parameter, so sending
 
=== modified file 'tests/modules/SessionManager/session_test.cpp'
--- tests/modules/SessionManager/session_test.cpp	2015-10-08 11:20:30 +0000
+++ tests/modules/SessionManager/session_test.cpp	2015-12-01 12:47:17 +0000
@@ -58,7 +58,7 @@
     EXPECT_EQ(Session::Starting, session->state());
 
     FakeMirSurface *surface = new FakeMirSurface;
-    session->setSurface(surface);
+    session->registerSurface(surface);
 
     // Still on Starting as the surface hasn't drawn its first frame yet
     EXPECT_EQ(Session::Starting, session->state());
@@ -228,7 +228,7 @@
     auto session = std::make_shared<qtmir::Session>(mirSession, mirServer->the_prompt_session_manager());
     {
         FakeMirSurface *surface = new FakeMirSurface;
-        session->setSurface(surface);
+        session->registerSurface(surface);
         surface->drawFirstFrame();
     }
     EXPECT_EQ(Session::Running, session->state());
@@ -259,7 +259,7 @@
     auto session = std::make_shared<qtmir::Session>(mirSession, mirServer->the_prompt_session_manager());
     {
         FakeMirSurface *surface = new FakeMirSurface;
-        session->setSurface(surface);
+        session->registerSurface(surface);
         surface->drawFirstFrame();
     }
     EXPECT_EQ(Session::Running, session->state());
 
=== modified file 'tests/modules/common/fake_mirsurface.h'
--- tests/modules/common/fake_mirsurface.h	2015-11-25 15:38:39 +0000
+++ tests/modules/common/fake_mirsurface.h	2015-12-01 12:47:17 +0000
@@ -142,6 +142,8 @@
         updateVisibility();
     }
 
+    void consumeBuffer() override {}
+
     // methods called from the rendering (scene graph) thread:
     QSharedPointer<QSGTexture> texture() override { return QSharedPointer<QSGTexture>(); }
     QSGTexture *weakTexture() const override { return nullptr; }
 
=== modified file 'tests/modules/common/fake_session.h'
--- tests/modules/common/fake_session.h	2015-10-20 09:57:17 +0000
+++ tests/modules/common/fake_session.h	2015-12-01 12:47:17 +0000
@@ -38,7 +38,8 @@
 
     QString name() const override { return QString("foo-session"); }
     unity::shell::application::ApplicationInfoInterface* application() const override { return m_application; }
-    MirSurfaceInterface* surface() const override { return nullptr; }
+    MirSurfaceInterface* lastSurface() const override { return nullptr; }
+    const ObjectListModel<MirSurfaceInterface>* surfaces() const override { return nullptr; }
     SessionInterface* parentSession() const override { return nullptr; }
     SessionModel* childSessions() const override { return nullptr; }
     State state() const override { return m_state; }
@@ -49,7 +50,8 @@
 
     // For MirSurfaceItem and MirSurfaceManager use
 
-    void setSurface(MirSurfaceInterface*) override {}
+    void registerSurface(MirSurfaceInterface*) override {}
+    void removeSurface(MirSurfaceInterface*) override {}
 
     // For Application use
 
 
=== modified file 'tests/modules/common/mock_session.h'
--- tests/modules/common/mock_session.h	2015-08-31 09:51:28 +0000
+++ tests/modules/common/mock_session.h	2015-12-01 12:47:17 +0000
@@ -36,16 +36,22 @@
 
     MOCK_CONST_METHOD0(name, QString());
     MOCK_CONST_METHOD0(application, unity::shell::application::ApplicationInfoInterface*());
-    MOCK_CONST_METHOD0(surface, MirSurfaceInterface*());
+    MOCK_CONST_METHOD0(lastSurface, MirSurfaceInterface*());
+    MOCK_CONST_METHOD0(surfaces, const ObjectListModel<MirSurfaceInterface>*());
     MOCK_CONST_METHOD0(parentSession, SessionInterface*());
+    MOCK_CONST_METHOD0(childSessions, SessionModel*());
 
     MOCK_CONST_METHOD0(state, State());
 
     MOCK_CONST_METHOD0(fullscreen, bool());
     MOCK_CONST_METHOD0(live, bool());
 
+    MOCK_CONST_METHOD0(session, std::shared_ptr<mir::scene::Session>());
+
+    MOCK_METHOD1(registerSurface, void(MirSurfaceInterface* surface));
+    MOCK_METHOD1(removeSurface, void(MirSurfaceInterface* surface));
+
     MOCK_METHOD1(setApplication, void(unity::shell::application::ApplicationInfoInterface* item));
-    MOCK_METHOD1(setSurface, void(MirSurfaceInterface* surface));
 
     MOCK_METHOD0(suspend, void());
     MOCK_METHOD0(resume, void());
@@ -56,13 +62,9 @@
     MOCK_METHOD1(removeChildSession, void(SessionInterface* session));
     MOCK_CONST_METHOD1(foreachChildSession, void(std::function<void(SessionInterface* session)> f));
 
-    MOCK_CONST_METHOD0(session, std::shared_ptr<mir::scene::Session>());
-
     MOCK_CONST_METHOD0(activePromptSession, std::shared_ptr<mir::scene::PromptSession>());
     MOCK_CONST_METHOD1(foreachPromptSession, void(std::function<void(const std::shared_ptr<mir::scene::PromptSession>&)> f));
 
-    MOCK_CONST_METHOD0(childSessions, SessionModel*());
-
     void setState(State state) {
         if (m_state != state) {
             m_state = state;