Code review comment for lp:~dandrader/qtmir/keyState
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
On 21/03/2017 09:37, Gerry Boland wrote:
> This appears to be a QML subtlety we're working around, as a non-QML Qt shell would not suffer from this issue, right?
Yes. As I said, QQuickWindow input dispatching not perfectly suited for
shells.
> So could the MirSurfaceItem keep track of the key state itself?
Sure.
> If the MSI looses activeFocus, it send key-release to the client. Then if it gets focus again, check if key is still down (not sure how tbh, maybe QML sends the key to the Item again immediately??), and if so, re-send it to client.
It can't check the key state, but it can ignore a key-up for a key that
it didn't tell its surface it was down (because lied or whatever).
> I'm not 100% certain what is the best approach yet.
Working around QQuickWindow input dispatching will never be beautiful. So, should I go for the MirSurfaceItem-
I'm fine either way. I put in the policy to avoid sending fake input to clients and as a general rule-of-thumb of "putting things in the miral policy"/"keep the policy in the loop".