Code review comment for lp:~dandrader/qtmir/keyState

Revision history for this message
Gerry Boland (gerboland) wrote :

If the surface looses active focus, don't we inform Mir? Why not send the key release event then? Would be more efficient than checking on every key_up

Also, please avoid using singleton pattern, it makes testing impossible. And speaking of which, can you add test?

review: Needs Information

« Back to merge proposal