Code review comment for lp:~dandrader/qtmir/allowClientResize
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> On 08/03/2017 09:17, Gerry Boland wrote:
> > + auto extraWindowInfo = getExtraInfo(
> > const auto & <- to save a copy?
>
> Are you sure? getExtraInfo() returns a std::shared_ptr<>. Won't move
> semantics take care of that?
The times that 'const auto&' gains over 'const auto' are mostly those when the function returns a reference.
For any function that returns a type (i.e. not a reference) it is very likely that RVO "takes care of it" and invoking move semantics would actually be less efficient.