Code review comment for lp:~dandrader/qtmir/allowClientResize

Revision history for this message
Gerry Boland (gerboland) wrote :

- CanonicalWindowManagerPolicy::handle_modify_window(windowInfo, modifications);
+ tools.modify_window(window_info, modifications);

I'd prefer you kept the reference to the CanonicalWindowManagerPolicy, for consistency. We're trying to use as much Mir code as possible (even though it is trivial)

+ auto extraWindowInfo = getExtraInfo(windowInfo);
const auto & <- to save a copy?

review: Needs Fixing

« Back to merge proposal