Mir

Code review comment for lp:~dandrader/mir/switchingBundle_lp1270964

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not sure that using boost is a better solution. Mostly because boost is so hideously documented that it's often very hard for the reader to learn what a particular template is/does. If using an additional variable lets you create a solution that the reader will understand immediately (no new library to learn), then that would have been better.

Now I kind of understand boost::optional, I think it's a dangerous template to use. Because assigning to an optional and testing its boolean value are essentially unrelated values. That's asking to be misinterpreted (as I have already today).

But this new version looks correct also.

review: Approve

« Back to merge proposal