I think we need a discussion about migrating this code into our codebase. We obviously relax our rules for style in 3rd_party, but under include, src or test it ought to conform.
237 +using mir::input::android::FakeEventHub; 238 +using namespace android;
Nit, but project style is to use namespace aliases in preference to bringing names into global namespace.
~~~~
242 + const nsecs_t ARBITRARY_TIME = 1234;
UPPERCASE is reserved for macros - http://unity.ubuntu.com/mir/cppguide/index.html?showone=Constant_Names#Constant_Names
« Back to merge proposal
I think we need a discussion about migrating this code into our codebase. We obviously relax our rules for style in 3rd_party, but under include, src or test it ought to conform.
237 +using mir::input: :android: :FakeEventHub;
238 +using namespace android;
Nit, but project style is to use namespace aliases in preference to bringing names into global namespace.
~~~~
242 + const nsecs_t ARBITRARY_TIME = 1234;
UPPERCASE is reserved for macros - http:// unity.ubuntu. com/mir/ cppguide/ index.html? showone= Constant_ Names#Constant_ Names