Code review comment for lp:~dandrader/geis/lp984069

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> On 04/24/2012 09:52 AM, Daniel d'Andrada wrote:
> >> (2) Not sure why you did all the fancy wrangling in
> >> testsuite/gtest/Makefile.am to provide multiple libraries instead of just
> >> including the xorg-gtest sources conditionally on ENABLE_INTEGRATION_TESTS.
> >> Could you make your reasoning explicit?
> >
> > That's another way of doing it. But I prefer the separation method since
> "That way we can have tests that depend on gtest but not on xorg-gtest" and
> therefore tests can link against only what they are going to use. Tests that
> use xmock will use gtest but never xorg-gtest, evemu or the fixtures included
> in libgtest_geis.
>
> But you know that for the last 40 years or so linkers only pull objects out of
> archives if they're used, so the only
> difference between using a single library and using multiple libraries is one
> of increased maintenance cost and
> confusion about which library to use?

I can do single library approach, no problem.

« Back to merge proposal