Code review comment for lp:~dandrader/geis/lp984069

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> (2) Not sure why you did all the fancy wrangling in
> testsuite/gtest/Makefile.am to provide multiple libraries instead of just
> including the xorg-gtest sources conditionally on ENABLE_INTEGRATION_TESTS.
> Could you make your reasoning explicit?

That's another way of doing it. But I prefer the separation method since "That way we can have tests that depend on gtest but not on xorg-gtest" and therefore tests can link against only what they are going to use. Tests that use xmock will use gtest but never xorg-gtest, evemu or the fixtures included in libgtest_geis.

« Back to merge proposal