Code review comment for lp:~dandrader/frame/backend

Revision history for this message
Chase Douglas (chasedouglas) wrote :

* In frame_device_get_property(), the value parameter should be reinterpret_cast'd instead of static_cast'd. The same is true for frame_frame_get_property(). Casts from void* to a concrete pointer should always be reinterpret casted (according to thumper).

* frame_frame_get_property_unsigned_int_() has an erroneously added empty line at the top.

Everything else looks good. I'm approving based on these changes. Great stuff!

review: Approve

« Back to merge proposal