Merge lp:~dandrader/compiz/lp1084162 into lp:compiz/0.9.9

[Daniel d'Andrada]

Point to compiz library dir in compiz.pc Libs section
Otherwise linkers won't be able to find, let say, -lcompiz_core if compiz is
installed outside /usr. (LP: #1084162)

Fixes bug 1084162

[Sam Spilsbury (smspillaz)]

This seems fine to me but r2993 states that:

  Revert the compiz.pc part of the fix for LP: #928044 because it caused some
  packages like libcompizconfig to link to compiz_core when they shouldn't.
  (LP: #929443)

Can you check with ldd whether or not this is happening?

[Daniel d'Andrada (dandrader)]

> This seems fine to me but r2993 states that:
>
> Revert the compiz.pc part of the fix for LP: #928044 because it caused some
> packages like libcompizconfig to link to compiz_core when they shouldn't.
> (LP: #929443)
>
> Can you check with ldd whether or not this is happening?

I just added the -L... part -lcompiz_core remain absent, which I think is the part necessary to cause the problem described.

[Sam Spilsbury (smspillaz)]

Ak ok, sounds good then

On Thu, Nov 29, 2012 at 2:08 AM, Daniel d'Andrada
<email address hidden> wrote:
>> This seems fine to me but r2993 states that:
>>
>> Revert the compiz.pc part of the fix for LP: #928044 because it caused some
>> packages like libcompizconfig to link to compiz_core when they shouldn't.
>> (LP: #929443)
>>
>> Can you check with ldd whether or not this is happening?
>
> I just added the -L... part -lcompiz_core remain absent, which I think is the part necessary to cause the problem described.
> --
> https://code.launchpad.net/~dandrader/compiz/lp1084162/+merge/136735
> Your team Compiz Maintainers is requested to review the proposed merge of lp:~dandrader/compiz/lp1084162 into lp:compiz.

--
Sam Spilsbury

[Sam Spilsbury (smspillaz)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3487
http://jenkins.qa.ubuntu.com/job/compiz-ci/275/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/275/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/275//rebuild/?

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

I remember adding that comment in r2993. But it's only an issue for the separate projects compiz-core/compiz-*plugins of 0.9.7.* for precise.

So if the change works with lp:compiz and lp:unity then it's fine.

review: Approve

=== modified file 'compiz.pc.in'
--- compiz.pc.in	2012-05-16 17:40:13 +0000
+++ compiz.pc.in	2012-11-28 17:55:35 +0000
@@ -8,5 +8,5 @@
 Version: @VERSION@
 
 Requires: @COMPIZ_REQUIRES@
-Libs:
+Libs: -L${libdir}
 Cflags: @COMPIZ_CFLAGS@ -I${includedir}/compiz