Code review comment for lp:~dale-f-beaudoin/unity-control-center/security_privacy

Revision history for this message
ventrical (dale-f-beaudoin) wrote :

still got text conflict in changelog
Here is what I have been following from Seb

The steps would be basically
$ bzr branch lp:unity-control-center
$ cd unity-control-center
$ editor debian/rules

do your changes

$ dch -i

write your changelog entry

$ bzr commit
$ bzr push lp:~<USER_ID>/unity-control-center/<BRANCH_NAME>

where USER_ID is your launchpad user id and BRANCH_NAME a name for your work

$ bzr lp-open

and do the merge proposal from the UI

and

----------------------------

Some comments though

- "unity7maintainers" doesn't really describe your branch, usually you would pick a name that explains what the change do, e.g "update-distro-serie"

- your commit message is not really good (see on the webpage mentioned earlier)

"--message
modified:
  debian/changelog
  debian/rules"
the commit should explain the change, copying what you wrote in the debian/changelog is a common practice there

So that is what I did but , as I mentioned to Seb , it seems that nano is really borking up the changelog. Ill keep trying..

« Back to merge proposal