Code review comment for lp:~daker/webbrowser-app/fix.1212980
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Looks great!
A couple of additional remarks before we can merge it:
- The component ids ('authDialog' and 'proxyAuthDialog') are unused here, you can safely remove them.
- Can you regenerate the translation templates now that there are new strings available? To do that, you will need to explicitly re-run cmake, then "make webbrowser-