webbrowser-app

Code review comment for lp:~daker/webbrowser-app/fix.1212980

  1. fix.1212980
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

A suggestion:

20 + onAccepted: model.accept(usernameInput.text, passwordInput.text)
27 + onAccepted: model.accept(usernameInput.text, passwordInput.text)
33 + onClicked: model.accept(usernameInput.text, passwordInput.text)

You might want to factor out this code into an accept() function.

« Back to merge proposal