Merge lp:~daker/ubuntu-ui-toolkit/fix.1665938 into lp:ubuntu-ui-toolkit/staging
Proposed by
Adnane Belmadiaf
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Cris Dywan | ||||
Proposed branch: | lp:~daker/ubuntu-ui-toolkit/fix.1665938 | ||||
Merge into: | lp:ubuntu-ui-toolkit/staging | ||||
Diff against target: |
16 lines (+4/-2) 1 file modified
src/imports/Components/1.3/PageStack.qml (+4/-2) |
||||
To merge this branch: | bzr merge lp:~daker/ubuntu-ui-toolkit/fix.1665938 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cris Dywan | Needs Fixing | ||
Review via email: mp+317804@code.launchpad.net |
Commit message
Fix Pagestack backAction icon in RTL mode
Description of the change
I used the "next" icon in RTL mode since the arrow needs to point to the right instead of the left
To post a comment you must log in.
Unmerged revisions
- 2175. By Adnane Belmadiaf
-
Fix comment
- 2174. By Adnane Belmadiaf
-
Fix Pagestack backAction in RTL mode
I'm afraid this is wrong. We have two options, one of which is practicable here:
1) Use Image.mirror: in the implementation of the Back button. Not feasible here because Action is used to define the button. it/ucscalingima geprovider. cpp to recognize -rtl as per the xdg icon spec to use alternative icon, in which case I'd recommend a second bug report. I can help out with the implementation as needed.
2) Add back-rtl.svg to the theme (Suru). This may also require a patch to src/UbuntuToolk