Merge lp:~daker/ubuntu-ui-toolkit/fix.1665938 into lp:ubuntu-ui-toolkit/staging

[Adnane Belmadiaf]

Fix Pagestack backAction icon in RTL mode

I used the "next" icon in RTL mode since the arrow needs to point to the right instead of the left

[lp:~daker/ubuntu-ui-toolkit/fix.1665938]

2175. By Adnane Belmadiaf on 2017-02-21

Fix comment

[Christian Dywan (kalikiana)]

I'm afraid this is wrong. We have two options, one of which is practicable here:

1) Use Image.mirror: in the implementation of the Back button. Not feasible here because Action is used to define the button.
2) Add back-rtl.svg to the theme (Suru). This may also require a patch to src/UbuntuToolkit/ucscalingimageprovider.cpp to recognize -rtl as per the xdg icon spec to use alternative icon, in which case I'd recommend a second bug report. I can help out with the implementation as needed.

review: Needs Fixing

Unmerged revisions

2175. By Adnane Belmadiaf on 2017-02-21

Fix comment

2174. By Adnane Belmadiaf on 2017-02-20

Fix Pagestack backAction in RTL mode

=== modified file 'src/imports/Components/1.3/PageStack.qml'
--- src/imports/Components/1.3/PageStack.qml	2016-05-25 12:48:10 +0000
+++ src/imports/Components/1.3/PageStack.qml	2017-02-21 00:45:31 +0000
@@ -219,8 +219,10 @@
         // used when the Page has a Page.header property set.
         id: backAction
         visible: pageStack.depth > 1
-        iconName: "back"
-        text: "Back"
+        // in RTL mode the arrow should point to the right, 
+        // so we will just use "next" as icon
+        iconName: Qt.application.layoutDirection == Qt.RightToLeft ? "next": "back"
+        text: i18n.tr("Back")
         onTriggered: pageStack.pop()
         objectName: "pagestack_back_action"
     }