Merge lp:~daker/ubuntu-rssreader-app/fix.1217297 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

[Adnane Belmadiaf]

Clicking on link should open it on the browser

[Joey Chan (qqworini)]

use Text to replace label ? seems Text can't handle different resolution with dynamic font size

[Roman Shchekin (mrqtros)]

I also think that it is bad solution for bug in SDK.

2013/9/6 Joey Chan <email address hidden>

> use Text to replace label ? seems Text can't handle different resolution
> with dynamic font size
> --
>
> https://code.launchpad.net/~daker/ubuntu-rssreader-app/fix.1217297/+merge/184213
> Your team Ubuntu RSS Feed Reader Developers is requested to review the
> proposed merge of lp:~daker/ubuntu-rssreader-app/fix.1217297 into
> lp:ubuntu-rssreader-app.
>

[David Planella (dpm)]

Roman, Joey, do you have any other suggestions on how to fix this?

Roman, you mentioned a bug in the SDK, is this bug already filed, and if not, would you mind filing it at https://bugs.launchpad.net/ubuntu-ui-toolkit/+filebug ?

Also, if the current branch does not fix the issue as per the expected results, please use the "Review" dropdown box below the comments to set the status of your comment to "Needs Fixing" or "Disapprove", so that the submitter knows about the status of the review. (For "Needs Fixing", please add a description of what needs fixing, and for "Disapprove", please add a reason why).

Thanks!

[Roman Shchekin (mrqtros)]

Hi, David.

Of course we have - someone from UI toolkit team should fix it :)
Since this bug appears only in Label component, it is not bug in Qt.
Especially if this bug appears only on device.

BR,
Roman.

2013/9/25 David Planella <email address hidden>

> Roman, Joey, do you have any other suggestions on how to fix this?
>
> Roman, you mentioned a bug in the SDK, is this bug already filed, and if
> not, would you mind filing it at
> https://bugs.launchpad.net/ubuntu-ui-toolkit/+filebug ?
>
> Also, if the current branch does not fix the issue as per the expected
> results, please use the "Review" dropdown box below the comments to set the
> status of your comment to "Needs Fixing" or "Disapprove", so that the
> submitter knows about the status of the review. (For "Needs Fixing", please
> add a description of what needs fixing, and for "Disapprove", please add a
> reason why).
>
> Thanks!
> --
>
> https://code.launchpad.net/~daker/ubuntu-rssreader-app/fix.1217297/+merge/184213
> Your team Ubuntu RSS Feed Reader Developers is requested to review the
> proposed merge of lp:~daker/ubuntu-rssreader-app/fix.1217297 into
> lp:ubuntu-rssreader-app.
>

[David Planella (dpm)]

Right, but unless there is a bug filed detailing the bug and how to reproduce it, it will not come to the attention of the SDK developers.

The SDK team is quite busy trying to get all the features and critical bug fixes in for 13.10, so I'm sure they'll appreciate the initiative in filing the bug including rich details and a reproducer, so that they can triage it and prioritize it.

You guys know the code best, and things like why we need to use Label instead of Text, so if you could give a hand in filing it at https://bugs.launchpad.net/ubuntu-ui-toolkit/+filebug that'd be awesome. Thanks!

[David Planella (dpm)]

Marking the branch as rejected, as it's now been superseded by https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/content-link-clickable/+merge/191167

Unmerged revisions

60. By Adnane Belmadiaf on 2013-09-05

Clicking on link should open them on the browser

=== modified file 'RssFeedPage.qml'
--- RssFeedPage.qml	2013-09-03 16:58:01 +0000
+++ RssFeedPage.qml	2013-09-06 00:06:27 +0000
@@ -112,13 +112,15 @@
                     wrapMode: Text.WrapAtWordBoundaryOrAnywhere
                 }
 
-                Label {
+                Text {
                     text: content
                     linkColor: UbuntuColors.orange // Temporary. Mb bad color, but better than dark blue.
+                    color: "#fff"
                     anchors.horizontalCenter: parent.horizontalCenter
                     width: parent.width - units.gu(4)
                     wrapMode: Text.WrapAtWordBoundaryOrAnywhere
                     clip: true
+                    onLinkActivated: Qt.openUrlExternally(link)
                 }
 
                 Label {