Merge lp:~daker/loco-team-portal/pep8-fixes into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 588
Merged at revision: 588
Proposed branch: lp:~daker/loco-team-portal/pep8-fixes
Merge into: lp:loco-team-portal
Diff against target: 563 lines (+76/-57)
17 files modified
loco_directory/articles/admin.py (+1/-0)
loco_directory/articles/management/commands/refresh.py (+3/-4)
loco_directory/articles/models.py (+4/-5)
loco_directory/articles/tests.py (+1/-0)
loco_directory/articles/views.py (+1/-1)
loco_directory/events/admin.py (+1/-1)
loco_directory/meetings/admin.py (+1/-1)
loco_directory/teams/admin.py (+6/-2)
loco_directory/teams/feeds.py (+1/-4)
loco_directory/teams/forms.py (+4/-5)
loco_directory/teams/models.py (+9/-1)
loco_directory/teams/tests.py (+9/-10)
loco_directory/teams/utils.py (+1/-1)
loco_directory/teams/views.py (+27/-17)
loco_directory/userprofiles/admin.py (+2/-0)
loco_directory/userprofiles/management/commands/update-profiles.py (+2/-3)
loco_directory/userprofiles/tests.py (+3/-2)
To merge this branch: bzr merge lp:~daker/loco-team-portal/pep8-fixes
Reviewer Review Type Date Requested Status
LoCo Team Portal Developers Pending
Review via email: mp+141242@code.launchpad.net

Commit message

PEP8 fixes

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'loco_directory/articles/admin.py'
--- loco_directory/articles/admin.py 2012-06-01 22:28:09 +0000
+++ loco_directory/articles/admin.py 2012-12-25 22:04:21 +0000
@@ -1,3 +1,4 @@
1# -*- coding: utf-8 -*-
1from articles.models import Feed, Article2from articles.models import Feed, Article
2from django.contrib import admin3from django.contrib import admin
34
45
=== modified file 'loco_directory/articles/management/commands/refresh.py'
--- loco_directory/articles/management/commands/refresh.py 2012-12-12 22:46:30 +0000
+++ loco_directory/articles/management/commands/refresh.py 2012-12-25 22:04:21 +0000
@@ -1,14 +1,13 @@
1# -*- coding: utf-8 -*-
1'''2'''
2Updates all Feeds3Updates all Feeds
3'''4'''
5from django.core.management.base import NoArgsCommand
46
7from articles.models import Feed
5import os8import os
6import datetime9import datetime
710
8from django.core.management.base import NoArgsCommand
9
10from articles.models import Feed
11
12REFRESH_LOCK = '/var/lock/loco-directory/refresh'11REFRESH_LOCK = '/var/lock/loco-directory/refresh'
1312
1413
1514
=== modified file 'loco_directory/articles/models.py'
--- loco_directory/articles/models.py 2012-12-13 22:48:12 +0000
+++ loco_directory/articles/models.py 2012-12-25 22:04:21 +0000
@@ -1,15 +1,14 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2from django.db import models
3from django.conf import settings
4from django.template.defaultfilters import slugify
5
2import feedparser6import feedparser
3import time7import time
4import datetime8import datetime
5import socket9import socket
6import urllib210import urllib2
711
8from django.db import models
9from django.conf import settings
10from django.template.defaultfilters import slugify
11
12
13from teams.models import Team12from teams.models import Team
14from userprofiles.models import UserProfile13from userprofiles.models import UserProfile
1514
1615
=== modified file 'loco_directory/articles/tests.py'
--- loco_directory/articles/tests.py 2012-12-11 00:00:46 +0000
+++ loco_directory/articles/tests.py 2012-12-25 22:04:21 +0000
@@ -1,3 +1,4 @@
1# -*- coding: utf-8 -*-
1from django.test import TestCase2from django.test import TestCase
23
3from articles.models import Feed, Article4from articles.models import Feed, Article
45
=== modified file 'loco_directory/articles/views.py'
--- loco_directory/articles/views.py 2012-12-13 22:48:12 +0000
+++ loco_directory/articles/views.py 2012-12-25 22:04:21 +0000
@@ -14,4 +14,4 @@
14 'article': article,14 'article': article,
15 }15 }
16 return render_to_response('articles/article_detail.html',16 return render_to_response('articles/article_detail.html',
17 context, RequestContext(request))17 context, RequestContext(request))
1818
=== modified file 'loco_directory/events/admin.py'
--- loco_directory/events/admin.py 2012-12-22 23:22:32 +0000
+++ loco_directory/events/admin.py 2012-12-25 22:04:21 +0000
@@ -1,6 +1,6 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2from django.contrib import admin2from django.contrib import admin
3from .models import *3from .models import (Venue, GlobalEvent, TeamEvent, Attendee)
44
55
6class TeamEventAdmin(admin.ModelAdmin):6class TeamEventAdmin(admin.ModelAdmin):
77
=== modified file 'loco_directory/meetings/admin.py'
--- loco_directory/meetings/admin.py 2012-12-04 21:25:51 +0000
+++ loco_directory/meetings/admin.py 2012-12-25 22:04:21 +0000
@@ -1,6 +1,6 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2from django.contrib import admin2from django.contrib import admin
3from meetings.models import *3from meetings.models import (TeamMeeting, AgendaItem)
44
5admin.site.register(TeamMeeting)5admin.site.register(TeamMeeting)
6admin.site.register(AgendaItem)6admin.site.register(AgendaItem)
77
=== modified file 'loco_directory/teams/admin.py'
--- loco_directory/teams/admin.py 2010-08-24 13:47:33 +0000
+++ loco_directory/teams/admin.py 2012-12-25 22:04:21 +0000
@@ -3,21 +3,25 @@
3from django.contrib import admin3from django.contrib import admin
4from teams.models import Team, Continent, Country, Language4from teams.models import Team, Continent, Country, Language
55
6
6class TeamAdmin(admin.ModelAdmin):7class TeamAdmin(admin.ModelAdmin):
7 search_fields = ('name',)8 search_fields = ('name',)
8 9
9 def formfield_for_dbfield(self, db_field, **kwargs):10 def formfield_for_dbfield(self, db_field, **kwargs):
10 field = super(TeamAdmin, self).formfield_for_dbfield(db_field, **kwargs)11 field = super(TeamAdmin, self).formfield_for_dbfield(db_field, **kwargs)
11 if db_field.name == 'description':12 if db_field.name == 'description':
12 field.widget.attrs['rows'] = '4'13 field.widget.attrs['rows'] = '4'
13 return field14 return field
14 15
16
15class ContinentAdmin(admin.ModelAdmin):17class ContinentAdmin(admin.ModelAdmin):
16 search_fields = ('name',)18 search_fields = ('name',)
1719
20
18class CountryAdmin(admin.ModelAdmin):21class CountryAdmin(admin.ModelAdmin):
19 search_fields = ('name',)22 search_fields = ('name',)
2023
24
21class LanguageAdmin(admin.ModelAdmin):25class LanguageAdmin(admin.ModelAdmin):
22 search_fields = ('name',)26 search_fields = ('name',)
2327
2428
=== modified file 'loco_directory/teams/feeds.py'
--- loco_directory/teams/feeds.py 2012-11-26 23:07:59 +0000
+++ loco_directory/teams/feeds.py 2012-12-25 22:04:21 +0000
@@ -1,7 +1,6 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2from django.core.exceptions import ObjectDoesNotExist2from django.core.exceptions import ObjectDoesNotExist
3from django.core.urlresolvers import reverse3from django.contrib.syndication.feeds import Feed
4from django.contrib.syndication.feeds import Feed, FeedDoesNotExist
5from django.utils.translation import ugettext as _4from django.utils.translation import ugettext as _
6from meetings.models import TeamMeeting5from meetings.models import TeamMeeting
7from events.models import TeamEvent6from events.models import TeamEvent
@@ -52,5 +51,3 @@
52 return obj.get_absolute_url()51 return obj.get_absolute_url()
53 else:52 else:
54 return '/'53 return '/'
55
56
5754
=== modified file 'loco_directory/teams/forms.py'
--- loco_directory/teams/forms.py 2012-03-04 20:55:07 +0000
+++ loco_directory/teams/forms.py 2012-12-25 22:04:21 +0000
@@ -1,12 +1,10 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2
3from django import forms2from django import forms
4from django.utils.translation import ugettext_lazy as _
53
6from models import Team4from models import Team
7from userprofiles.models import UserProfile
8from common.forms import RenderableMixin5from common.forms import RenderableMixin
96
7
10class UpdateTeamForm(forms.ModelForm, RenderableMixin):8class UpdateTeamForm(forms.ModelForm, RenderableMixin):
11 class Meta:9 class Meta:
12 model = Team10 model = Team
@@ -14,12 +12,13 @@
1412
15 class Media:13 class Media:
16 css = {'all': (14 css = {'all': (
17 '/media/css/colortip-1.0-jquery.css', 15 '/media/css/colortip-1.0-jquery.css',
18 )}16 )}
19 js = (17 js = (
20 '/media/js/colortip-1.0-jquery.js',18 '/media/js/colortip-1.0-jquery.js',
21 )19 )
2220
21
23class LoCoCouncilForm(UpdateTeamForm, RenderableMixin):22class LoCoCouncilForm(UpdateTeamForm, RenderableMixin):
24 class Meta(UpdateTeamForm.Meta):23 class Meta(UpdateTeamForm.Meta):
25 model = Team24 model = Team
2625
=== modified file 'loco_directory/teams/models.py'
--- loco_directory/teams/models.py 2012-11-18 22:02:56 +0000
+++ loco_directory/teams/models.py 2012-12-25 22:04:21 +0000
@@ -3,10 +3,10 @@
3from django.db import models3from django.db import models
4from django.utils.translation import ugettext_lazy as _4from django.utils.translation import ugettext_lazy as _
55
6from common.utils import flat_list
7from common.mixins import LocalTimeMixin6from common.mixins import LocalTimeMixin
8from userprofiles.models import UserProfile7from userprofiles.models import UserProfile
98
9
10class Language(models.Model):10class Language(models.Model):
11 class Meta:11 class Meta:
12 ordering = ('name',)12 ordering = ('name',)
@@ -16,9 +16,11 @@
16 def __unicode__(self):16 def __unicode__(self):
17 return u'%s' % (self.name)17 return u'%s' % (self.name)
1818
19
19class TeamManager(models.Manager):20class TeamManager(models.Manager):
20 pass21 pass
2122
23
22class Continent(models.Model):24class Continent(models.Model):
23 name = models.TextField(_("Name"), max_length=50)25 name = models.TextField(_("Name"), max_length=50)
2426
@@ -41,6 +43,7 @@
41 def related_teams(self):43 def related_teams(self):
42 return Team.objects.filter(countries__continents=self).distinct()44 return Team.objects.filter(countries__continents=self).distinct()
4345
46
44class Country(models.Model):47class Country(models.Model):
45 name = models.TextField(_("Name"), max_length=100)48 name = models.TextField(_("Name"), max_length=100)
46 continents = models.ManyToManyField(Continent)49 continents = models.ManyToManyField(Continent)
@@ -66,21 +69,25 @@
66 else:69 else:
67 return 'no_country'70 return 'no_country'
6871
72
69def countries_without_continent():73def countries_without_continent():
70 return Country.objects.filter(continents__isnull=True)74 return Country.objects.filter(continents__isnull=True)
7175
76
72def countries_without_continent_have_venues():77def countries_without_continent_have_venues():
73 for country in countries_without_continent():78 for country in countries_without_continent():
74 if country.venue_set.count() > 0:79 if country.venue_set.count() > 0:
75 return True80 return True
76 return False81 return False
7782
83
78def countries_without_continent_have_teams():84def countries_without_continent_have_teams():
79 for country in countries_without_continent():85 for country in countries_without_continent():
80 if country.team_set.count() > 0:86 if country.team_set.count() > 0:
81 return True87 return True
82 return False88 return False
8389
90
84class Team(models.Model, LocalTimeMixin):91class Team(models.Model, LocalTimeMixin):
85 lp_name = models.CharField(_("Launchpad Team ID"), max_length=40, null=True)92 lp_name = models.CharField(_("Launchpad Team ID"), max_length=40, null=True)
86 name = models.CharField(_("Team Name"), max_length=80, null=False, default='')93 name = models.CharField(_("Team Name"), max_length=80, null=False, default='')
@@ -150,5 +157,6 @@
150 events_and_meetings = events_and_meetings[:5]157 events_and_meetings = events_and_meetings[:5]
151 return events_and_meetings158 return events_and_meetings
152159
160
153def teams_without_country():161def teams_without_country():
154 return Team.objects.filter(countries__isnull=True)162 return Team.objects.filter(countries__isnull=True)
155163
=== modified file 'loco_directory/teams/tests.py'
--- loco_directory/teams/tests.py 2012-11-28 00:46:29 +0000
+++ loco_directory/teams/tests.py 2012-12-25 22:04:21 +0000
@@ -1,16 +1,12 @@
1from django.test import TestCase1from django.test import TestCase
2from django.contrib.auth.models import User, Group
2from django.core.urlresolvers import reverse3from django.core.urlresolvers import reverse
3from urllib import urlencode4from urllib import urlencode
4
5from django.contrib.auth.models import User, Group
6
7from django_openid_auth.models import UserOpenID5from django_openid_auth.models import UserOpenID
8from userprofiles.models import UserProfile
9from teams.models import *6from teams.models import *
10from common import launchpad7from common import launchpad
118
129
13
14class TestBase(TestCase):10class TestBase(TestCase):
1511
16 def setUp(self):12 def setUp(self):
@@ -60,6 +56,7 @@
60 self.user_foo.groups.add(self.team_group)56 self.user_foo.groups.add(self.team_group)
61 self.user_foo.save()57 self.user_foo.save()
6258
59
63class ACLChecksTestCase(TestBase):60class ACLChecksTestCase(TestBase):
6461
65 def testAdminIsATeamChecks(self):62 def testAdminIsATeamChecks(self):
@@ -69,6 +66,7 @@
69 self.assertEquals(launchpad.is_admin_or_owner(self.user_foo.username, team), True)66 self.assertEquals(launchpad.is_admin_or_owner(self.user_foo.username, team), True)
70 self.assertEquals(launchpad.is_admin_or_owner(self.user_bar.username, team), False)67 self.assertEquals(launchpad.is_admin_or_owner(self.user_bar.username, team), False)
7168
69
72class EditTeamTestCase(TestBase):70class EditTeamTestCase(TestBase):
73 """71 """
74 test if team update works correct72 test if team update works correct
@@ -79,12 +77,12 @@
79 """77 """
80 #try to access team-update page as not logged in user78 #try to access team-update page as not logged in user
8179
82 data = { 'next' : '/teams/test-team/edit' }80 data = {'next': '/teams/test-team/edit'}
83 response = self.client.get(reverse( 'team-edit', args=['test-team'] ), follow=True)81 response = self.client.get(reverse('team-edit', args=['test-team']), follow=True)
84 self.assertRedirects(response, '/openid/login/?%s' % urlencode(data), status_code=302, target_status_code=200)82 self.assertRedirects(response, '/openid/login/?%s' % urlencode(data), status_code=302, target_status_code=200)
8583
86 #try to update team as not logged in user84 #try to update team as not logged in user
87 response = self.client.post(reverse('team-edit', args=['test-team']), {'Country':'Germany', 'forum_url':'http://ubuntuusers.de'}, follow=True)85 response = self.client.post(reverse('team-edit', args=['test-team']), {'Country': 'Germany', 'forum_url': 'http://ubuntuusers.de'}, follow=True)
88 self.assertRedirects(response, '/openid/login/?%s' % urlencode(data), status_code=302, target_status_code=200)86 self.assertRedirects(response, '/openid/login/?%s' % urlencode(data), status_code=302, target_status_code=200)
8987
90 def test_user_with_no_rights(self):88 def test_user_with_no_rights(self):
@@ -108,6 +106,7 @@
108 pass106 pass
109 #FIXME How to use a user with this rights with openid?107 #FIXME How to use a user with this rights with openid?
110108
109
111class DisplayNameTestCase(TestBase):110class DisplayNameTestCase(TestBase):
112111
113 def test_override_name(self):112 def test_override_name(self):
@@ -135,5 +134,5 @@
135 response = self.client.get('/teams/test-team/')134 response = self.client.get('/teams/test-team/')
136 self.assertEquals(response.status_code, 200)135 self.assertEquals(response.status_code, 200)
137136
138 self.assertContains(response, 'Override Name', 0) # No instances of override_name137 self.assertContains(response, 'Override Name', 0) # No instances of override_name
139 self.assertContains(response, 'Test Team', 4) # One instance of the team name138 self.assertContains(response, 'Test Team', 4) # One instance of the team name
140139
=== modified file 'loco_directory/teams/utils.py'
--- loco_directory/teams/utils.py 2011-02-17 13:04:25 +0000
+++ loco_directory/teams/utils.py 2012-12-25 22:04:21 +0000
@@ -2,6 +2,7 @@
22
3from events.models import TeamEvent3from events.models import TeamEvent
44
5
5def merge_teams(old_team, new_team):6def merge_teams(old_team, new_team):
6 msgs = []7 msgs = []
7 related_events = TeamEvent.objects.filter(teams__id=old_team.id)8 related_events = TeamEvent.objects.filter(teams__id=old_team.id)
@@ -60,4 +61,3 @@
60 old_team.delete()61 old_team.delete()
61 msgs += [ugettext('Team "%(old_team)s" merged with "%(new_team)s".' % {'old_team':old_team.name, 'new_team':new_team.name})]62 msgs += [ugettext('Team "%(old_team)s" merged with "%(new_team)s".' % {'old_team':old_team.name, 'new_team':new_team.name})]
62 return msgs63 return msgs
63
6464
=== modified file 'loco_directory/teams/views.py'
--- loco_directory/teams/views.py 2012-12-18 22:35:47 +0000
+++ loco_directory/teams/views.py 2012-12-25 22:04:21 +0000
@@ -19,10 +19,10 @@
19from articles.models import Article19from articles.models import Article
2020
21import forms21import forms
22
23import datetime22import datetime
24import vobject23import vobject
2524
25
26def reapprovals(request):26def reapprovals(request):
27 teams = filter(lambda a: a.approved and a.expires_date != None,27 teams = filter(lambda a: a.approved and a.expires_date != None,
28 Team.objects.all().order_by('expires_date', 'name'))28 Team.objects.all().order_by('expires_date', 'name'))
@@ -31,11 +31,11 @@
31# XXX: we have no idea why, but on loco.ubuntu.com we are dealing with31# XXX: we have no idea why, but on loco.ubuntu.com we are dealing with
32# datetime.datetime instead of datetime.date - bug 58164132# datetime.datetime instead of datetime.date - bug 581641
33 if type(teams[0].expires_date) == datetime.datetime:33 if type(teams[0].expires_date) == datetime.datetime:
34 next_teams = filter(lambda a: a.expires_date.date() <= today+half_a_year, teams)34 next_teams = filter(lambda a: a.expires_date.date() <= today + half_a_year, teams)
35 later_teams = filter(lambda a: a.expires_date.date() > today+half_a_year, teams)35 later_teams = filter(lambda a: a.expires_date.date() > today + half_a_year, teams)
36 else:36 else:
37 next_teams = filter(lambda a: a.expires_date <= today+half_a_year, teams)37 next_teams = filter(lambda a: a.expires_date <= today + half_a_year, teams)
38 later_teams = filter(lambda a: a.expires_date > today+half_a_year, teams)38 later_teams = filter(lambda a: a.expires_date > today + half_a_year, teams)
39 context = {39 context = {
40 'next_teams': next_teams,40 'next_teams': next_teams,
41 'later_teams': later_teams,41 'later_teams': later_teams,
@@ -43,6 +43,7 @@
43 return render_to_response('teams/team_reapprovals.html',43 return render_to_response('teams/team_reapprovals.html',
44 context, RequestContext(request))44 context, RequestContext(request))
4545
46
46def as_ical(objects, name):47def as_ical(objects, name):
47 """Return any list events as an ical"""48 """Return any list events as an ical"""
48 filename = "%s.ics" % name.replace(' ', '-').lower()49 filename = "%s.ics" % name.replace(' ', '-').lower()
@@ -61,6 +62,7 @@
6162
62 return response63 return response
6364
65
64def team_list(request):66def team_list(request):
65 continents = Continent.objects.all().order_by('name')67 continents = Continent.objects.all().order_by('name')
66 for continent in continents:68 for continent in continents:
@@ -75,17 +77,19 @@
75 'countries_without_continent': all_countries_without_continent,77 'countries_without_continent': all_countries_without_continent,
76 'countries_without_continent_have_teams': countries_without_continent_have_teams(),78 'countries_without_continent_have_teams': countries_without_continent_have_teams(),
77 'teams_without_country': teams_without_country().order_by('name'),79 'teams_without_country': teams_without_country().order_by('name'),
78 'colcycle' : simple_iterator('col_left', 'col_right'),80 'colcycle': simple_iterator('col_left', 'col_right'),
79 }81 }
80 return render_to_response('teams/team_list.html', context,82 return render_to_response('teams/team_list.html', context,
81 RequestContext(request))83 RequestContext(request))
8284
85
83def get_events_and_meetings(team_object):86def get_events_and_meetings(team_object):
84 team_events = list(TeamEvent.objects.filter(teams=team_object))87 team_events = list(TeamEvent.objects.filter(teams=team_object))
85 team_meetings = list(TeamMeeting.objects.filter(teams=team_object))88 team_meetings = list(TeamMeeting.objects.filter(teams=team_object))
86 team_events.extend(team_meetings)89 team_events.extend(team_meetings)
87 return team_events90 return team_events
8891
92
89def team_ical(request, team_slug):93def team_ical(request, team_slug):
90 """94 """
91 Return a ical list with the events and meetings in ical format.95 Return a ical list with the events and meetings in ical format.
@@ -93,6 +97,7 @@
93 team_object = get_object_or_404(Team, lp_name=team_slug)97 team_object = get_object_or_404(Team, lp_name=team_slug)
94 return as_ical(get_events_and_meetings(team_object), team_object.name)98 return as_ical(get_events_and_meetings(team_object), team_object.name)
9599
100
96def team_event_list(request, team_slug):101def team_event_list(request, team_slug):
97 """102 """
98 list with all team events in present and future for the given team103 list with all team events in present and future for the given team
@@ -105,11 +110,12 @@
105 context = {110 context = {
106 'team_object': team_object,111 'team_object': team_object,
107 'team_event_list': team_event_list,112 'team_event_list': team_event_list,
108 'is_member' : is_member,113 'is_member': is_member,
109 }114 }
110 return render_to_response('teams/team_event_list.html', context,115 return render_to_response('teams/team_event_list.html', context,
111 RequestContext(request))116 RequestContext(request))
112117
118
113def team_event_history(request, team_slug):119def team_event_history(request, team_slug):
114 """120 """
115 list with all team events in past for the given team121 list with all team events in past for the given team
@@ -123,6 +129,7 @@
123 return render_to_response('teams/team_event_history.html', context,129 return render_to_response('teams/team_event_history.html', context,
124 RequestContext(request))130 RequestContext(request))
125131
132
126def team_meeting_list(request, team_slug):133def team_meeting_list(request, team_slug):
127 """134 """
128 list with all team meetings in present and future for the given team135 list with all team meetings in present and future for the given team
@@ -136,6 +143,7 @@
136 return render_to_response('teams/team_meeting_list.html', context,143 return render_to_response('teams/team_meeting_list.html', context,
137 RequestContext(request))144 RequestContext(request))
138145
146
139def team_meeting_history(request, team_slug):147def team_meeting_history(request, team_slug):
140 """148 """
141 list with all team meetings in past for the given team149 list with all team meetings in past for the given team
@@ -180,11 +188,12 @@
180 team_list = Team.objects.all().order_by('name')188 team_list = Team.objects.all().order_by('name')
181 other_teams = team_list.exclude(id=team_object.id)189 other_teams = team_list.exclude(id=team_object.id)
182 return render_to_response('teams/select_other_team.html',190 return render_to_response('teams/select_other_team.html',
183 {'team_object':team_object,191 {'team_object': team_object,
184 'other_teams':other_teams,192 'other_teams': other_teams,
185 'user':request.user,193 'user': request.user,
186 }, RequestContext(request))194 }, RequestContext(request))
187195
196
188@login_required197@login_required
189def team_merge(request, team_slug, other_team_slug):198def team_merge(request, team_slug, other_team_slug):
190 old_team = get_object_or_404(Team, lp_name=team_slug)199 old_team = get_object_or_404(Team, lp_name=team_slug)
@@ -202,9 +211,9 @@
202 request.user.message_set.create(message=msg)211 request.user.message_set.create(message=msg)
203212
204 return render_to_response('teams/merge_teams.html',213 return render_to_response('teams/merge_teams.html',
205 {'team_object':old_team,214 {'team_object': old_team,
206 'other_team_object':new_team,215 'other_team_object': new_team,
207 'user':request.user,216 'user': request.user,
208 }, RequestContext(request))217 }, RequestContext(request))
209218
210219
@@ -218,7 +227,7 @@
218 is_contact = launchpad.is_admin_or_owner(request.user.username, team_object)227 is_contact = launchpad.is_admin_or_owner(request.user.username, team_object)
219 if not is_on_lc and not is_contact:228 if not is_on_lc and not is_contact:
220 request.user.message_set.create(message=ugettext('You are not allowed to make changes to the team details.'))229 request.user.message_set.create(message=ugettext('You are not allowed to make changes to the team details.'))
221 return redirect( team_object )230 return redirect(team_object)
222231
223 if request.method == "POST":232 if request.method == "POST":
224 if is_on_lc:233 if is_on_lc:
@@ -228,7 +237,7 @@
228 if form.is_valid():237 if form.is_valid():
229 form.save()238 form.save()
230 request.user.message_set.create(message=ugettext('Thanks, your team\'s details have been saved.'))239 request.user.message_set.create(message=ugettext('Thanks, your team\'s details have been saved.'))
231 return redirect( team_object )240 return redirect(team_object)
232 else:241 else:
233 request.user.message_set.create(message=ugettext('Recent changes to your team\'s details could not be saved.'))242 request.user.message_set.create(message=ugettext('Recent changes to your team\'s details could not be saved.'))
234 else:243 else:
@@ -239,10 +248,11 @@
239248
240 return render_to_response('teams/team_update.html',249 return render_to_response('teams/team_update.html',
241 {'form': form,250 {'form': form,
242 'team':team_object,251 'team': team_object,
243 'user':request.user,252 'user': request.user,
244 }, RequestContext(request))253 }, RequestContext(request))
245254
255
246def xml_team_data(request):256def xml_team_data(request):
247 XMLSerializer = serializers.get_serializer("xml")257 XMLSerializer = serializers.get_serializer("xml")
248 xml_serializer = XMLSerializer()258 xml_serializer = XMLSerializer()
249259
=== modified file 'loco_directory/userprofiles/admin.py'
--- loco_directory/userprofiles/admin.py 2010-08-24 13:47:33 +0000
+++ loco_directory/userprofiles/admin.py 2012-12-25 22:04:21 +0000
@@ -1,6 +1,8 @@
1# -*- coding: utf-8 -*-
1from django.contrib import admin2from django.contrib import admin
2from userprofiles.models import UserProfile3from userprofiles.models import UserProfile
34
5
4class UserProfileAdmin(admin.ModelAdmin):6class UserProfileAdmin(admin.ModelAdmin):
5 search_fields = ('realname',)7 search_fields = ('realname',)
68
79
=== modified file 'loco_directory/userprofiles/management/commands/update-profiles.py'
--- loco_directory/userprofiles/management/commands/update-profiles.py 2012-11-19 22:53:54 +0000
+++ loco_directory/userprofiles/management/commands/update-profiles.py 2012-12-25 22:04:21 +0000
@@ -3,13 +3,12 @@
33
4from django.core.management.base import BaseCommand4from django.core.management.base import BaseCommand
5from django.contrib.auth.models import User5from django.contrib.auth.models import User
6from optparse import make_option
67
7from userprofiles.models import create_userprofile8from userprofiles.models import create_userprofile
8
9from optparse import make_option
10from datetime import datetime
11import sys9import sys
1210
11
13class Command(BaseCommand):12class Command(BaseCommand):
14 help = "Updates user profiles with information from Launchpad."13 help = "Updates user profiles with information from Launchpad."
15 option_list = BaseCommand.option_list + (14 option_list = BaseCommand.option_list + (
1615
=== modified file 'loco_directory/userprofiles/tests.py'
--- loco_directory/userprofiles/tests.py 2012-11-18 22:02:56 +0000
+++ loco_directory/userprofiles/tests.py 2012-12-25 22:04:21 +0000
@@ -1,10 +1,11 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2from django.test import TestCase2from django.test import TestCase
3from django.contrib.auth.models import User3from django.contrib.auth.models import User
4from django.db.models import signals4from django.db.models import signals
55
6from userprofiles.models import UserProfile6from userprofiles.models import UserProfile
77
8
8class SignalTest(TestCase):9class SignalTest(TestCase):
9 '''10 '''
10 Tests that signals fire properly11 Tests that signals fire properly
@@ -27,4 +28,4 @@
27 def test_profile_creation(self):28 def test_profile_creation(self):
28 self.user = User.objects.create(username='bob', password='bob')29 self.user = User.objects.create(username='bob', password='bob')
29 self.user.save()30 self.user.save()
30 self.assertEqual(UserProfile.objects.all().count(), 1)
31\ No newline at end of file31\ No newline at end of file
32 self.assertEqual(UserProfile.objects.all().count(), 1)

Subscribers

People subscribed via source and target branches