Merge lp:~daker/loco-team-portal/fix.656761 into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Merged at revision: 314
Proposed branch: lp:~daker/loco-team-portal/fix.656761
Merge into: lp:loco-team-portal
Diff against target: 18 lines (+5/-5)
1 file modified
loco_directory/teams/urls.py (+5/-5)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.656761
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+38025@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

This fixes parts of the problem:
 - http://127.0.0.1:8000/teams/ubuntu-ar/ works as expected
 - http://127.0.0.1:8000/teams/ubuntu-ar works as expected
 - http://127.0.0.1:8000/teams/ubuntu-ar/events works as expected
but
 - http://127.0.0.1:8000/teams/ubuntu-ar/events/ shows the team page

review: Needs Fixing
310. By Adnane Belmadiaf

Another Fix to team urls

Revision history for this message
Daniel Holbach (dholbach) wrote :

http://127.0.0.1:8000/teams/ubuntu-ar/events still brings me to the team page.

review: Needs Fixing
311. By Adnane Belmadiaf

Another fix to teams app url

Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'loco_directory/teams/urls.py'
--- loco_directory/teams/urls.py 2010-09-30 16:14:48 +0000
+++ loco_directory/teams/urls.py 2010-10-18 13:57:47 +0000
@@ -3,9 +3,9 @@
3urlpatterns = patterns('',3urlpatterns = patterns('',
4 url(r'^$', 'teams.views.team_list', name='team-list'),4 url(r'^$', 'teams.views.team_list', name='team-list'),
5 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/edit$', 'teams.views.team_edit', name='team-edit'),5 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/edit$', 'teams.views.team_edit', name='team-edit'),
6 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/merge$', 'teams.views.select_other_team', name='select-other-team'),6 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/merge/(?P<other_team_slug>[a-zA-Z0-9\-\.\+?]+)/$', 'teams.views.team_merge', name='team-merge'),
7 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/merge/(?P<other_team_slug>[a-zA-Z0-9\-\.\+?]+)$', 'teams.views.team_merge', name='team-merge'),7 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/merge', 'teams.views.select_other_team', name='select-other-team'),
8 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/events/history$', 'teams.views.team_event_history', name='team-event-history'),8 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/events/history', 'teams.views.team_event_history', name='team-event-history'),
9 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/events$', 'teams.views.team_event_list', name='team-event-list'),9 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/events', 'teams.views.team_event_list', name='team-event-list'),
10 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)$', 'teams.views.team_detail', name='team-detail'),10 url(r'(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)', 'teams.views.team_detail', name='team-detail'),
11)11)

Subscribers

People subscribed via source and target branches