Code review comment for lp:~daggerstab/stellarium/comets-asteroids-importer
Revision history for this message
| Matthew Gates (matthew-porpoisehead) wrote | # |
review:
Abstain
(usage)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
First impressions - really good plugin - I think a lot of people will appreciate this one.
GUI:
1 Not sure if we need the path of the ssystem.ini printed. Perhaps just a "reset" option to delete user copy. I realize this won't if the ssystem.ini is messed up so much the program won't start, but then this message can't be seen, and for sure users won't remember it.
(2) If we don't have to have the big warning and path of user ssystem.ini, maybe we can also dispense with the Copy / Restore thing?
(3) Internet search timer somewhat annoying. It makes user wait for a minute if they /didn't/ find what they were looking for (at which point they will probably want to re-search straight away). Unless we get complaints of overloading from the search server people, I don't think we need the limit, although maybe we should set the user agent to something they can use to throttle us if they want rather than have a generic user agent (assuming we use http to connect).
(4) Maybe the search can just be a tab in the main window rather than a separate tab (if (1) & (2) are accepted, the first tab is not really necessary - just a restore button somewhere.
Just my 2 pence worth!
-
Minor bugs noticed:
- long names of downloaded objects get truncated to 20 characters.