Code review comment for lp:~d6g/do-plugins/GDocs

2008/09/27 Ciro Alinei

Egregio Alex Buongiorno a te,

intanto no en qui per ovvie ragioni, grazie. °Veniamo poi a questo
argomento. Fatto è
ke intendo abbonarmi a GDocs per avere dunque un server di archivi 'da
muovere'.
Io qui ti saluto. Che cosa attendo ?? Una lista di programmi trial
'per passare da Windows a Linux' onde vedere senza intervenire
sui valori del boot.

Cordiali e grazie

2008/9/27 Peng Deng <email address hidden>

> According to Google's API documents:
>
> Files may be uploaded using the UploadDocument method of the service
> object. In the examples below, the complete file name with its path,
> along with an optional name of the file to be used in Google Docs is
> provided to the UploadDocument function. If null is passed as the file
> name, then the original file name on the disk will be used in Google
> Docs.
>
> It seems ok to use 'null'.
>
> Code has been cleaned to comply mono guidelines.
>
> Cheers,
> P.D.
>
>
>
> On Sat, Sep 27, 2008 at 7:27 AM, Alex Launi <email address hidden> wrote:
> > Vote: Abstain
> > GDocsUploadDocument.cs : 92
> > public IItem[] Perform (IItem[] items, IItem[] modifierItems)
> > {
> > string fileName = (items[0] as IFileItem).Path;
> > string documentName = (modifierItems.Length > 0) ?
> (modifierItems[0] as ITextItem).Text : null;
> >
> > IItem returnItem;
> > returnItem = GDocs.UploadDocument (fileName,
> documentName);
> >
> > Why null? Does the GDocs library handle this elegantly? Why not make
> documentName = fileName or something? If GDocs knows what to do with a null
> 2nd parameter, withouth crashing ever than this is ok, but are you sure
> that's totally legal?
> >
> > Still has Mono guidelines issues, especially in GDocs.cs, mostly issues
> with spaces between methods and their parenthesis.
> >
> > That's it from me, fix those couple of things (the one might not even
> need fixed if that's cool with google), and you're into main!
> >
> > --
> > https://code.launchpad.net/~d6g/do-plugins/GDocs/+merge/990<https://code.launchpad.net/%7Ed6g/do-plugins/GDocs/+merge/990>
> > You are subscribed to branch Google Docs Plugin.
> >
> --
> https://code.launchpad.net/~d6g/do-plugins/GDocs/+merge/990<https://code.launchpad.net/%7Ed6g/do-plugins/GDocs/+merge/990>
> You are subscribed to branch GDocuments Plugin.
>

--
                  CIRO ALINEI ROMA