Code review comment for ~d0ugal/maas:release-notification-setting

Revision history for this message
Kit Randel (blr) wrote :

That was the design agreed upon
https://app.zeplin.io/project/5efa65801b4d9162739308fc/screen/5f16b3b5311acb77fa0925d7

On Tue, Jul 28, 2020 at 12:38 PM Lee Trager <email address hidden>
wrote:

> Review: Needs Information
>
> Why are we making this a configuration option? None of our other
> notifications are optional. The data will be coming from the MAAS streams
> so it will be downloaded regardless.
> --
> https://code.launchpad.net/~d0ugal/maas/+git/maas/+merge/388137
> Your team MAAS Committers is subscribed to branch maas:master.
>
> Launchpad-Message-Rationale: Subscriber @maas-committers
> Launchpad-Message-For: maas-committers
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~maas-committers/maas/+git/maas:master
> Launchpad-Project: maas
>

--
Kit Randel (blr)
Canonical - Web Team

« Back to merge proposal