Code review comment for ~d0ugal/maas-images:release-notifications

Revision history for this message
Lee Trager (ltrager) wrote :

lp:maas-images doesn't do much checking I'm not opposed to adding it but we should validate the format as well. Using

re.search('\d+\.\d+\.\d+', release_notification["maas_version"])

is a bit better because not only does it validate that its a string but a string in the format you expect. Without the regex you could set the version to "Dougal" :)

« Back to merge proposal