Code review comment for ~d-info-e/cloud-init:fix-user-group-doc

Revision history for this message
do3meli (d-info-e) wrote :

i haven't tested it but just looking at the code i assume you think that line 133 is the one that converts '-' into '_', right?

see https://git.launchpad.net/cloud-init/tree/cloudinit/distros/ug_util.py#n133

it definitely makes sense to be consistent in the docs as well as the actual implementation. so i will make sure that cloudinit/config/cc_users_groups.py is correct too.

on the other hand i am unsure if ssh-import-id and ssh-authorized-keys are identical. i will dig into that further later on.

« Back to merge proposal