Code review comment for ~d-info-e/cloud-init:resizefs-on-zfs-root

Revision history for this message
do3meli (d-info-e) wrote :

the last commit fixes the problem mentioned above in my environment. i haven't run into this problem with unit tests as i mocked the return value and did not follow the logic in the code. another zfs exclusion in the if/else construct fixed it now.

regarding the curtin stuff. i see it the same way as you:
the cc_resizefs module calls 'get_mount_info' which then on linux will call the 'parse_mount_info' function. as i haven't adjusted the get_mount_info nor the parse_mount_info functions it will at least not break any existing system. on the other hand as you mentioned as well it is not guaranteed to be working for zfs/zpool on ubuntu for example.

so i am good to go ahead with this now. please re-trigger a CI run.

« Back to merge proposal