Merge lp:~cyruslien/ubiquity/fix-1716369 into lp:ubiquity

[Cyrus Lien]

Add dbus exception handling for:
dbus.exceptions.DBusException: org.freedesktop.NetworkManager.Settings.Connection.Failed: Failed to determine AP security information

The error was generated when trying to connect a wpa enterprise ap. (lp:1716369)

[Mathieu Trudel-Lapierre (cyphermox)]

I have nothing against guarding this piece of code against failure, but are you sure this is the correct branch to fix the bug you were seeing?

As far as I can tell, the bug open about this is for WPA Enterprise support, and recent rework of ubiquity for WPA should have properly added support for WPA enterprise. Can you please test the behavior without this patch on artful so we know if we should backport things to xenial?

review: Needs Information

[Cyrus Lien (cyruslien)]

Tried Artful daily build, the WPA Enterprise behavior works very well. Please backport WPA Enterprise support to xenial, also this patch is unnecessary. Thanks!

[Mathieu Trudel-Lapierre (cyphermox)]

Rejected since the WPA enterprise support should be backported to xenial instead.

review: Disapprove

Unmerged revisions

6564. By Cyrus Lien on 2017-09-12

Handle dbus exception when connecting to wpa enterprise ap. (LP: #1716369)

=== modified file 'ubiquity/nm.py'
--- ubiquity/nm.py	2015-09-15 21:04:13 +0000
+++ ubiquity/nm.py	2017-09-12 05:33:04 +0000
@@ -175,10 +175,13 @@
         obj = dbus.Dictionary(signature='sa{sv}')
         if passphrase:
             obj['802-11-wireless-security'] = {'psk': passphrase}
-        self.active_conn, self.active_connection = (
-            self.manager.AddAndActivateConnection(
+        try:
+            self.active_conn, self.active_connection = (
+             self.manager.AddAndActivateConnection(
                 obj, dbus.ObjectPath(device), dbus.ObjectPath(saved_path),
                 signature='a{sa{sv}}oo'))
+        except dbus.DBusException:
+               return 
         self.active_device_obj = device_obj
 
     def disconnect_from_ap(self):