Merge lp:~cypressyew/checkbox/touchpad-requirement-fix into lp:checkbox

[Po-Hsu Lin]

Now all of the touchpad jobs are required to run in laptop/notebook/portable platforms.

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Daniel Manrique (roadmr)]

For the record, DMI type is quite unreliable when determining a system's form factor and this may cause inadequate skipping of tests in the future. We'll need a more reliable way at some point, although this is OK for the time being. Thanks for working on this!

[Zygmunt Krynicki (zyga)]

FYI: check my cep-6 https://blueprints.launchpad.net/plainbox/+spec/cep-6

On Mon, Jun 16, 2014 at 3:33 PM, Daniel Manrique <
<email address hidden>> wrote:

> For the record, DMI type is quite unreliable when determining a system's
> form factor and this may cause inadequate skipping of tests in the future.
> We'll need a more reliable way at some point, although this is OK for the
> time being. Thanks for working on this!
> --
>
> https://code.launchpad.net/~cypressyew/checkbox/touchpad-requirement-fix/+merge/223201
> You are reviewing the proposed merge of
> lp:~cypressyew/checkbox/touchpad-requirement-fix into lp:checkbox.
>

=== modified file 'providers/plainbox-provider-checkbox/jobs/touchpad.txt.in'
--- providers/plainbox-provider-checkbox/jobs/touchpad.txt.in	2014-05-09 16:53:32 +0000
+++ providers/plainbox-provider-checkbox/jobs/touchpad.txt.in	2014-06-16 08:14:07 +0000
@@ -65,6 +65,7 @@
 
 plugin: manual
 id: touchpad/multitouch-manual
+requires: dmi.product in ['Notebook','Laptop','Portable']
 depends: touchpad/singletouch-automated
 estimated_duration: 120.0
 _description:
@@ -77,6 +78,7 @@
 
 plugin: manual
 id: touchpad/singletouch-corner
+requires: dmi.product in ['Notebook','Laptop','Portable']
 estimated_duration: 120.0
 _description:
  PURPOSE:
@@ -90,6 +92,7 @@
 
 plugin: manual
 id: touchpad/singletouch-selection
+requires: dmi.product in ['Notebook','Laptop','Portable']
 estimated_duration: 120.0
 _description:
  PURPOSE:
@@ -102,6 +105,7 @@
 
 plugin: manual
 id: touchpad/multitouch-rightclick
+requires: dmi.product in ['Notebook','Laptop','Portable']
 depends: touchpad/multitouch-automated
 estimated_duration: 120.0
 _description:
@@ -116,6 +120,7 @@
 
 plugin: user-interact
 id: touchpad/multitouch-horizontal
+requires: dmi.product in ['Notebook','Laptop','Portable']
 command: touchpad_test right left
 estimated_duration: 120.0
 _description:
@@ -129,6 +134,7 @@
 
 plugin: user-interact
 id: touchpad/multitouch-vertical
+requires: dmi.product in ['Notebook','Laptop','Portable']
 command: touchpad_test up down
 estimated_duration: 120.0
 _description:
@@ -142,6 +148,7 @@
 
 plugin: manual
 id: touchpad/drag-and-drop
+requires: dmi.product in ['Notebook','Laptop','Portable']
 estimated_duration: 120.0
 _description:
  PURPOSE:
@@ -155,6 +162,7 @@
 
 plugin: manual
 id: touchpad/multitouch-zoom
+requires: dmi.product in ['Notebook','Laptop','Portable']
 depends: touchpad/multitouch-automated
 estimated_duration: 120.0
 _summary: Check touchpad pinch-to-zoom gesture
@@ -170,6 +178,7 @@
 
 plugin: manual
 id: touchpad/multitouch-dash
+requires: dmi.product in ['Notebook','Laptop','Portable']
 depends: touchpad/multitouch-automated
 estimated_duration: 120.0
 _summary: Check 4-finger tap gesture