Merge lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2076
Merged at revision: 2075
Proposed branch: lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc
Merge into: lp:checkbox
Diff against target: 52 lines (+9/-7)
3 files modified
debian/changelog (+4/-0)
jobs/led.txt.in (+2/-3)
jobs/suspend.txt.in (+3/-4)
To merge this branch: bzr merge lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Po-Hsu Lin Needs Resubmitting
Brendan Donegan (community) Needs Fixing
Review via email: mp+160541@code.launchpad.net

Description of the change

Modified the description about power LED in the jobs/suspend.txt.in and jobs/led.txt.in
To fit the behavior of a HP Pavilion 23 AIO.
(I guess some of the desktops will have the same behavior too.)

Rearranged the sentence too.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

debian/changelog entry, please :)

review: Needs Fixing
2076. By Po-Hsu Lin

Add a entry in debian/changelog

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Oops, thanks!

Resubmitted.

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-04-23 15:29:07 +0000
+++ debian/changelog 2013-04-24 08:53:28 +0000
@@ -7,6 +7,10 @@
7checkbox (0.15.8) raring; urgency=low7checkbox (0.15.8) raring; urgency=low
88
9 [ Po-Hsu Lin]9 [ Po-Hsu Lin]
10 * jobs/led.txt.in: Modified the description of led/power-blink-suspend test to
11 cover more cases.
12 jobs/suspend.txt.in: Modified the description of suspend/suspend_advanced
13 test cover more cases. (LP: #1172108)
10 * jobs/monitor.txt.in: Modified the description of dim_brightness test to make 14 * jobs/monitor.txt.in: Modified the description of dim_brightness test to make
11 it consistent with the code. (LP: #1170244)15 it consistent with the code. (LP: #1170244)
1216
1317
=== modified file 'jobs/led.txt.in'
--- jobs/led.txt.in 2013-04-19 13:40:29 +0000
+++ jobs/led.txt.in 2013-04-24 08:53:28 +0000
@@ -15,10 +15,9 @@
15 PURPOSE:15 PURPOSE:
16 Power LED verification16 Power LED verification
17 STEPS:17 STEPS:
18 1. The Power LED should blink while the system is suspended18 1. The Power LED should blink or change color while the system is suspended
19 VERIFICATION:19 VERIFICATION:
20 Did the Power LED blink while the system was suspended for the previous20 Did the Power LED blink or change color while the system was suspended for the previous suspend test?
21 suspend test?
2221
23plugin: manual22plugin: manual
24name: led/suspend23name: led/suspend
2524
=== modified file 'jobs/suspend.txt.in'
--- jobs/suspend.txt.in 2013-04-22 23:47:41 +0000
+++ jobs/suspend.txt.in 2013-04-24 08:53:28 +0000
@@ -178,13 +178,12 @@
178 This test will check suspend and resume178 This test will check suspend and resume
179 STEPS:179 STEPS:
180 1. Click "Test" and your system will suspend for about 30 - 60 seconds180 1. Click "Test" and your system will suspend for about 30 - 60 seconds
181 2. Observe the Power LED to see if it blinks during suspend181 2. Observe the Power LED to see if it blinks or changes color during suspend
182 3. If your system does not wake itself up after 60 seconds, please press the power button momentarily to wake the system manually182 3. If your system does not wake itself up after 60 seconds, please press the power button momentarily to wake the system manually
183 4. If your system fails to wake at all and must be rebooted, restart System Testing after reboot and mark this test as Failed183 4. If your system fails to wake at all and must be rebooted, restart System Testing after reboot and mark this test as Failed
184 VERIFICATION:184 VERIFICATION:
185 Did your system suspend and resume correctly? (NOTE: Please only consider185 Did your system suspend and resume correctly?
186 whether the system successfully suspended and resumed. Power/Suspend LED186 (NOTE: Please only consider whether the system successfully suspended and resumed. Power/Suspend LED verification will occur after this test is completed.)
187 verification will occur after this test is completed.)
188187
189plugin: shell188plugin: shell
190name: suspend/suspend_advanced_auto189name: suspend/suspend_advanced_auto

Subscribers

People subscribed via source and target branches