Checkbox

Merge lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc into lp:checkbox

  1. modify_LED_pwr_suspend_desc
  2. Merge into trunk
Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2076
Merged at revision: 2075
Proposed branch: lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc
Merge into: lp:checkbox
Diff against target: 52 lines (+9/-7)
3 files modified
debian/changelog (+4/-0)
jobs/led.txt.in (+2/-3)
jobs/suspend.txt.in (+3/-4)
To merge this branch: bzr merge lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Po-Hsu Lin Needs Resubmitting
Brendan Donegan (community) Needs Fixing
Review via email: mp+160541@code.launchpad.net

Description of the change

Modified the description about power LED in the jobs/suspend.txt.in and jobs/led.txt.in
To fit the behavior of a HP Pavilion 23 AIO.
(I guess some of the desktops will have the same behavior too.)

Rearranged the sentence too.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

debian/changelog entry, please :)

review: Needs Fixing
lp:~cypressyew/checkbox/modify_LED_pwr_suspend_desc updated
2076. By Po-Hsu Lin

Add a entry in debian/changelog

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Oops, thanks!

Resubmitted.

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-23 15:29:07 +0000
3+++ debian/changelog 2013-04-24 08:53:28 +0000
4@@ -7,6 +7,10 @@
5 checkbox (0.15.8) raring; urgency=low
6
7 [ Po-Hsu Lin]
8+ * jobs/led.txt.in: Modified the description of led/power-blink-suspend test to
9+ cover more cases.
10+ jobs/suspend.txt.in: Modified the description of suspend/suspend_advanced
11+ test cover more cases. (LP: #1172108)
12 * jobs/monitor.txt.in: Modified the description of dim_brightness test to make
13 it consistent with the code. (LP: #1170244)
14
15
16=== modified file 'jobs/led.txt.in'
17--- jobs/led.txt.in 2013-04-19 13:40:29 +0000
18+++ jobs/led.txt.in 2013-04-24 08:53:28 +0000
19@@ -15,10 +15,9 @@
20 PURPOSE:
21 Power LED verification
22 STEPS:
23- 1. The Power LED should blink while the system is suspended
24+ 1. The Power LED should blink or change color while the system is suspended
25 VERIFICATION:
26- Did the Power LED blink while the system was suspended for the previous
27- suspend test?
28+ Did the Power LED blink or change color while the system was suspended for the previous suspend test?
29
30 plugin: manual
31 name: led/suspend
32
33=== modified file 'jobs/suspend.txt.in'
34--- jobs/suspend.txt.in 2013-04-22 23:47:41 +0000
35+++ jobs/suspend.txt.in 2013-04-24 08:53:28 +0000
36@@ -178,13 +178,12 @@
37 This test will check suspend and resume
38 STEPS:
39 1. Click "Test" and your system will suspend for about 30 - 60 seconds
40- 2. Observe the Power LED to see if it blinks during suspend
41+ 2. Observe the Power LED to see if it blinks or changes color during suspend
42 3. If your system does not wake itself up after 60 seconds, please press the power button momentarily to wake the system manually
43 4. If your system fails to wake at all and must be rebooted, restart System Testing after reboot and mark this test as Failed
44 VERIFICATION:
45- Did your system suspend and resume correctly? (NOTE: Please only consider
46- whether the system successfully suspended and resumed. Power/Suspend LED
47- verification will occur after this test is completed.)
48+ Did your system suspend and resume correctly?
49+ (NOTE: Please only consider whether the system successfully suspended and resumed. Power/Suspend LED verification will occur after this test is completed.)
50
51 plugin: shell
52 name: suspend/suspend_advanced_auto

Subscribers

People subscribed via source and target branches