Code review comment for lp:~cypressyew/checkbox/fix-S3-S4-keys

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

I removed the dependency, also re-ordering the whitelist a little bit:
1. Move the __firmware__ back.
2. Move hybrid_sleep to after suspend
3. Move hibernate to run after all the *-after-suspend_* tests

I think the whitelist ordering is worthy of discussion, any suggestion is welcomed.
Thanks!

review: Needs Resubmitting

« Back to merge proposal