Code review comment for lp:~cypressyew/checkbox/fix-S3-S4-keys

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I don't quite understand why we're reordering the whitelist and not removing the (IMHO bogus) dependency on suspend itself.

While it's true that suspend and hibernate keys may be special and may not be applicable for "does this key work" test that simply intercepts the key and prevents its special function from working I don't understand why that key test actually needs to depend on the suspend job.

review: Needs Information

« Back to merge proposal