Merge lp:~cypressyew/checkbox/brightness-tolerance into lp:checkbox

[Po-Hsu Lin]

Use the absolute difference for brightness and actual_brightness and a tolerance value (now is 1) to determine the pass / fail of the dim brightness test.

[Sylvain Pineau (sylvain-pineau)]

Thanks, +1

review: Approve

[Sylvain Pineau (sylvain-pineau)]

The attempt to merge lp:~cypressyew/checkbox/brightness-tolerance into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.08user 0.07system 0:05.30elapsed 2%CPU (0avgtext+0avgdata 10196maxresident)k
[precise] (timing) 0inputs+32outputs (0major+8714minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/12999405/
[precise] stderr: http://paste.ubuntu.com/12999406/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.08user 0.07system 0:05.33elapsed 3%CPU (0avgtext+0avgdata 10196maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+8703minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/12999410/
[trusty] stderr: http://paste.ubuntu.com/12999411/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

=== modified file 'providers/plainbox-provider-checkbox/bin/brightness_test'
--- providers/plainbox-provider-checkbox/bin/brightness_test	2014-03-20 14:01:58 +0000
+++ providers/plainbox-provider-checkbox/bin/brightness_test	2015-10-26 09:31:53 +0000
@@ -130,8 +130,8 @@
         Note: this doesn't guarantee that screen brightness
               changed.
         '''
-        if (self.get_actual_brightness(interface) !=
-            self.get_last_set_brightness(interface)):
+        if (abs(self.get_actual_brightness(interface) -
+            self.get_last_set_brightness(interface)) > 1):
             return False
         else:
             return True